Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/observation multiple evidences #480

Merged
merged 23 commits into from
Apr 26, 2024
Merged

Feat/observation multiple evidences #480

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
42e1974
create observation document - observation join table
tsubik Dec 22, 2023
fa336a2
move evidence type to observation document and name it as document_type
tsubik Jan 3, 2024
4f2804f
fix migration
tsubik Jan 5, 2024
7e29cff
add observation_report reference to observation documents
tsubik Jan 5, 2024
70a3f5e
API changes for multiple evidences
tsubik Jan 9, 2024
0ba3e6e
fix observation document uploader
tsubik Jan 9, 2024
fa1d577
remove evidence_type from obs histories as this is no needed
tsubik Jan 11, 2024
66ee048
update migration saving old evidence_type as evidence_type_v0 in pape…
tsubik Jan 11, 2024
1d35c7b
fixing specs
tsubik Jan 11, 2024
f08477c
update model annotations
tsubik Jan 25, 2024
1bbfc41
add observation-report-id to observation document resource to not hav…
tsubik Jan 26, 2024
03151e8
add deleted_at to obs-documents-observations join table, update gener…
tsubik Jan 26, 2024
e6cab37
admin observation report show page: add documents/evidences
tsubik Jan 26, 2024
4d4dc1f
fix not visible documents on index page after moving observation to r…
tsubik Jan 26, 2024
8004ba0
change how admin can add and attach evidences to observations
tsubik Mar 20, 2024
00050a2
tweak observation form, show only relevant evidence inputs based on e…
tsubik Mar 20, 2024
db41407
fix problem with evidences that does not belong to report somehow
tsubik Mar 21, 2024
4a776f6
fix issue with uploader, validate evidence attachment
tsubik Mar 21, 2024
f8f947b
validate name for observation evidence
tsubik Mar 21, 2024
04a9c2d
fixing specs
tsubik Mar 21, 2024
077bc37
remove user from observation documents as it is not even used
tsubik Mar 21, 2024
d822b2f
fix permissions
tsubik Mar 21, 2024
8e24cc9
user reference was removed from observation document
tsubik Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing specs
  • Loading branch information
@tsubik
tsubik committed Mar 25, 2024
commit 04a9c2dd202b2f5717a671dbedc4dca3b5837eaf
3 changes: 2 additions & 1 deletion spec/integration/v1/observation_documents_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ module V1
create: {
success_roles: %i[admin],
failure_roles: %i[user],
valid_params: -> { {name: "Document one", relationships: {user: user.id, observation_report: observation_report.id}} }
valid_params: -> { {name: "Document one", attachment: document_data, relationships: {user: user.id, observation_report: observation_report.id}} },
excluded_params: %i[attachment] # workaround as after upload attachment is url and not base64
},
edit: {
success_roles: %i[admin],
Expand Down