Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/observation multiple evidences #480

Merged
merged 23 commits into from
Apr 26, 2024

Conversation

tsubik
Copy link
Collaborator

@tsubik tsubik commented Jan 11, 2024

Connect observation document with multiple observations, not only one.

@tsubik tsubik force-pushed the feat/observation-multiple-evidences branch from 2e3b163 to d909e74 Compare January 25, 2024 13:13
@tsubik tsubik marked this pull request as ready for review January 30, 2024 10:19
Copy link
Contributor

@santostiago santostiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

query = <<-SQL
INSERT INTO observation_documents_observations (observation_document_id, observation_id, created_at, updated_at)
SELECT
od.id, o.id, NOW(), NOW()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm. wouldn't it be better to keep the created_at and updated_at?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe you are right.

@tsubik tsubik force-pushed the feat/observation-multiple-evidences branch from 3c0d048 to ea99d57 Compare March 21, 2024 17:40
…r trail history, add attribute to read that value
@tsubik tsubik force-pushed the feat/observation-multiple-evidences branch from ea99d57 to 8e24cc9 Compare March 25, 2024 14:47
@tsubik tsubik merged commit 4364973 into develop Apr 26, 2024
4 checks passed
@tsubik tsubik deleted the feat/observation-multiple-evidences branch May 9, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants