Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL translations - package #2 #144

Merged
merged 9 commits into from
Apr 25, 2024
Merged

PL translations - package #2 #144

merged 9 commits into from
Apr 25, 2024

Conversation

ant2753
Copy link
Contributor

@ant2753 ant2753 commented Apr 23, 2024

Second pack of translations

Copy link
Member

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @ant2753, it seems the translation is now complete. Could you please confirm that the way you translated “The” into “-” is correct?

"helpLayerSoaringLayerDepth4": "Skala kolorów jest pokazana w prawym dolnym rogu ekranu.",
"helpLayerThermalVelocity": "Prędkość termiki szacuje się na podstawie wysokości warstwy granicznej i ocieplenia gruntu. Skala kolorów jest pokazana w prawym dolnym rogu ekranu.",
"helpMeteogramIntro": "Meteogramy pokazują prognozę pogody dla wybranej lokalizacji w czasie. Oto przykład trzydniowego meteogramu, który stworzyliśmy w celach ilustracyjnych:",
"helpMeteogramTopRow1": "-",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you often use this character. Is it correct or temporary?

@ant2753
Copy link
Contributor Author

ant2753 commented Apr 24, 2024

"-" might be where I went wrong. There is no "definite article" in polish corresponding to "the" and there should be "nothing" / "null" where I used "-". I did not know how to differentiate 1) translation not provided 2) correct translation is null/nothing for this context. Please advise how to proceed with that

@julienrf
Copy link
Member

Hello,

Here is a preview of how the Polish version looks like:

image

Would it be possible to shorten the menu entry “Wysokość warstwy granicznej”? For instance, in French, it is abbreviated to “Épaisseur couche conv.” instead of “Épaisseur couche convective”.

Here is the help for the meteograms:

image

If I understand correctly, you would like to remove the leading article/dash, as follows?

image

It seems the Fink UI does not let us type an “empty” translation, but we can do it manually in the translation files. I can push my changes if you confirm that they are correct :)

@ant2753
Copy link
Contributor Author

ant2753 commented Apr 24, 2024

With regards to this:
"layerSoaringLayerDepth": "Wysokość warstwy granicznej",
I would shorten to:
"Wysokość warstwy gr."

I tried to make this change in Fink. Not sure if succeeded to include in PullRequest.

Dash character "-" in place of "The" looks well in "help" - like non-numbered enumeration which looks like proper formatting for the context.

Both versions look well: with or without dash - please choose yourself (perhaps following consistency to other languages).

Yes, I believe translations are correct, please push to main.

@ant2753
Copy link
Contributor Author

ant2753 commented Apr 24, 2024

I can see now: ""Wysokość warstwy gr." was committed with today's date

@julienrf julienrf merged commit 5091266 into soaringmeteo:main Apr 25, 2024
1 check passed
@julienrf
Copy link
Member

Merged, thank you! Please sync your fork before working on the translations again :)

@julienrf
Copy link
Member

How do we say “Polish” in Polish? Is it “Polski”?

@ant2753
Copy link
Contributor Author

ant2753 commented Apr 25, 2024

Yes. "Polski" is proper menu entry for language choice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants