[core][c++ worker]Add namespace support for c++ worker #26327

WangTaoTheTonic · 2022-07-06T15:32:07Z

Why are these changes needed?

Namespace feature has been supported in Python/Java but not in c++ worker. All created actors are assigned with a default empty namespace.

With this change, users can use namespace in c++ worker like:

RayConfig config;
config.ray_namespace = "my_ns";
ray::Init(config, ..., ...);

Then all named actor created are under namespace my_ns, they're invisible to other namespaces.

auto test_actor = ray::Actor(...).setName("name", "test_ns").Remote();

Then test_actor is under namespace test_ns, it's only visible to those who is under same one.
User can also use api with namespace to get an actor:

ray::GetActor<...>(actor_name, namespace_name);

ray::GetActor with namespace
some more test cases

I'll file another PR to update the doc.

Related issue number

#26183

Checks

I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

jovany-wang · 2022-07-07T03:46:56Z

FYI: We are aiming to remove job config concept these days, see #26116
but I think we could merge this PR firstly, and then remove job config in C++ worker after that PR merged.

jovany-wang

Nice PR, I left some minor comments related code style and practices.

cpp/include/ray/api/ray_config.h

src/ray/util/util.h

cpp/include/ray/api.h

src/ray/util/util.h

…6327) Signed-off-by: Edward Oakes <[email protected]>

…6327) Signed-off-by: Nikita Vemuri <[email protected]>

…6327) Signed-off-by: Catch-Bull <[email protected]>

…d specifying namespace while creating/getting named actors (#26498) We've supported namespace in c++ worker in #26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++

…6327) Signed-off-by: Avnish <[email protected]>

…d specifying namespace while creating/getting named actors (ray-project#26498) We've supported namespace in c++ worker in ray-project#26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++ Signed-off-by: Avnish <[email protected]>

…d specifying namespace while creating/getting named actors (ray-project#26498) We've supported namespace in c++ worker in ray-project#26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++ Signed-off-by: Shreyas Krishnaswamy <[email protected]>

…d specifying namespace while creating/getting named actors (ray-project#26498) We've supported namespace in c++ worker in ray-project#26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++ Signed-off-by: nanqi.yxf <[email protected]>

…6327) Signed-off-by: klwuibm <[email protected]>

…d specifying namespace while creating/getting named actors (ray-project#26498) We've supported namespace in c++ worker in ray-project#26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++ Signed-off-by: klwuibm <[email protected]>

…d specifying namespace while creating/getting named actors (ray-project#26498) We've supported namespace in c++ worker in ray-project#26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++ Signed-off-by: Catch-Bull <[email protected]>

…d specifying namespace while creating/getting named actors (ray-project#26498) We've supported namespace in c++ worker in ray-project#26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++ Signed-off-by: Rohan138 <[email protected]>

…6327) Signed-off-by: Frank Luan <[email protected]>

…d specifying namespace while creating/getting named actors (ray-project#26498) We've supported namespace in c++ worker in ray-project#26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++ Signed-off-by: Frank Luan <[email protected]>

…6327) Signed-off-by: Scott Graham <[email protected]>

…d specifying namespace while creating/getting named actors (ray-project#26498) We've supported namespace in c++ worker in ray-project#26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++ Signed-off-by: Scott Graham <[email protected]>

…6327)

…d specifying namespace while creating/getting named actors (ray-project#26498) We've supported namespace in c++ worker in ray-project#26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++

…6327) Signed-off-by: Stefan van der Kleij <[email protected]>

…d specifying namespace while creating/getting named actors (ray-project#26498) We've supported namespace in c++ worker in ray-project#26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors. - [x] add doc for basic c++ worker namespace usage - [x] add explanation for specifying namespace while creating named actors, in Python, Java and C++ Signed-off-by: Stefan van der Kleij <[email protected]>

WangTaoTheTonic added 2 commits July 6, 2022 23:01

Add namespace support for c++ worker

205aa91

add a simple test

28a6e0a

WangTaoTheTonic requested a review from jovany-wang July 6, 2022 15:32

WangTaoTheTonic requested a review from SongGuyang as a code owner July 6, 2022 15:32

WangTaoTheTonic self-assigned this Jul 6, 2022

WangTaoTheTonic requested review from raulchen and mwtian as code owners July 6, 2022 15:32

WangTaoTheTonic added 2 commits July 7, 2022 10:32

lint

1eb5e49

add getActor(name, namespace) api

9e4ca3b

WangTaoTheTonic changed the title ~~[WIP][core][c++ worker]Add namespace support for c++ worker~~ [core][c++ worker]Add namespace support for c++ worker Jul 7, 2022

WangTaoTheTonic requested a review from stephanie-wang July 7, 2022 03:45

jovany-wang reviewed Jul 7, 2022

View reviewed changes

cpp/include/ray/api/ray_config.h Show resolved Hide resolved

src/ray/util/util.h Outdated Show resolved Hide resolved

raulchen approved these changes Jul 7, 2022

View reviewed changes

cpp/include/ray/api.h Outdated Show resolved Hide resolved

src/ray/util/util.h Outdated Show resolved Hide resolved

WangTaoTheTonic added 2 commits July 7, 2022 16:17

lint, comments

879f869

â�fix test

f760f3b

jovany-wang approved these changes Jul 7, 2022

View reviewed changes

WangTaoTheTonic added 2 commits July 8, 2022 11:01

fix test and add more

2531048

Merge branch 'master' into a_ns

309bc61

raulchen merged commit 1de0d35 into ray-project:master Jul 12, 2022

WangTaoTheTonic deleted the a_ns branch July 12, 2022 01:59

jovany-wang mentioned this pull request Jul 12, 2022

[Core][Minor] Remove unreachable code path for ray_namespace. #25305

Merged

6 tasks

WangTaoTheTonic mentioned this pull request Jul 13, 2022

[Doc][namespaces][C++ worker]add document for c++ worker namespace and specifying namespace while creating/getting named actors #26498

Merged

8 tasks

edoakes pushed a commit to edoakes/ray that referenced this pull request Jul 14, 2022

[core][c++ worker]Add namespace support for c++ worker (ray-project#2…

cffe221

…6327) Signed-off-by: Edward Oakes <[email protected]>

nikitavemuri pushed a commit to nikitavemuri/ray that referenced this pull request Jul 15, 2022

[core][c++ worker]Add namespace support for c++ worker (ray-project#2…

2836bbe

…6327) Signed-off-by: Nikita Vemuri <[email protected]>

Catch-Bull pushed a commit to alipay/ant-ray that referenced this pull request Jul 18, 2022

[core][c++ worker]Add namespace support for c++ worker (ray-project#2…

f2a2220

…6327) Signed-off-by: Catch-Bull <[email protected]>

Catch-Bull pushed a commit to alipay/ant-ray that referenced this pull request Jul 18, 2022

[core][c++ worker]Add namespace support for c++ worker (ray-project#2…

9acab82

…6327) Signed-off-by: Catch-Bull <[email protected]>

avnishn pushed a commit to smorad/ray that referenced this pull request Jul 20, 2022

[core][c++ worker]Add namespace support for c++ worker (ray-project#2…

18ca94c

…6327) Signed-off-by: Avnish <[email protected]>

klwuibm pushed a commit to yuanchi2807/ray that referenced this pull request Jul 27, 2022

[core][c++ worker]Add namespace support for c++ worker (ray-project#2…

fabc5ca

…6327) Signed-off-by: klwuibm <[email protected]>

franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022

[core][c++ worker]Add namespace support for c++ worker (ray-project#2…

07427e0

…6327) Signed-off-by: Frank Luan <[email protected]>

gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022

[core][c++ worker]Add namespace support for c++ worker (ray-project#2…

25248ea

…6327) Signed-off-by: Scott Graham <[email protected]>

gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022

[core][c++ worker]Add namespace support for c++ worker (ray-project#2…

8e924e9

…6327)

Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022

[core][c++ worker]Add namespace support for c++ worker (ray-project#2…

089f93c

…6327) Signed-off-by: Stefan van der Kleij <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core][c++ worker]Add namespace support for c++ worker #26327

[core][c++ worker]Add namespace support for c++ worker #26327

WangTaoTheTonic commented Jul 6, 2022 •

edited

Loading

jovany-wang commented Jul 7, 2022 •

edited

Loading

jovany-wang left a comment

[core][c++ worker]Add namespace support for c++ worker #26327

[core][c++ worker]Add namespace support for c++ worker #26327

Conversation

WangTaoTheTonic commented Jul 6, 2022 • edited Loading

Why are these changes needed?

Related issue number

Checks

jovany-wang commented Jul 7, 2022 • edited Loading

jovany-wang left a comment

Choose a reason for hiding this comment

WangTaoTheTonic commented Jul 6, 2022 •

edited

Loading

jovany-wang commented Jul 7, 2022 •

edited

Loading