Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][C++ worker]Support specifying namespace when creating actors. #26183

Closed
WangTaoTheTonic opened this issue Jun 29, 2022 · 4 comments
Closed
Assignees
Labels
C++ Worker enhancement Request for new feature and/or capability

Comments

@WangTaoTheTonic
Copy link
Contributor

WangTaoTheTonic commented Jun 29, 2022

Description

namespace implementation(doc) has been implemented in Java/Python, but still not in C++ worker.
Now user can't specify namespace when creating c++ actors, but the actors are all assigned a default empty namespace(like here).
We will support it ASAP in order to

  1. make namespace working in c++ worker
  2. make namespace behavior consistent in x-lang scenario.

File this issue to track it.

cc @jovany-wang

Use case

#25305 (comment)

@WangTaoTheTonic WangTaoTheTonic added the enhancement Request for new feature and/or capability label Jun 29, 2022
@WangTaoTheTonic WangTaoTheTonic self-assigned this Jun 29, 2022
@jovany-wang
Copy link
Contributor

Thanks a lot.
FYI, the code path in Java is https://github.com/ray-project/ray/blob/master/java/runtime/src/main/java/io/ray/runtime/config/RayConfig.java#L138-L139

@stephanie-wang stephanie-wang changed the title [<Ray component: Core|Cpp worker>] support anonymous namespace [core][C++ worker] support anonymous namespace Jun 29, 2022
@stephanie-wang
Copy link
Contributor

Please update the issue description and title to provide more context (explain what a namespace is and why we need it for C++ worker).

@WangTaoTheTonic WangTaoTheTonic changed the title [core][C++ worker] support anonymous namespace [core][C++ worker]Support specifying namespace when creating actors. Jul 6, 2022
@WangTaoTheTonic
Copy link
Contributor Author

WangTaoTheTonic commented Jul 6, 2022

Please update the issue description and title to provide more context (explain what a namespace is and why we need it for C++ worker).

Thanks for the reminding. I've update the description.

@WangTaoTheTonic
Copy link
Contributor Author

PR merged. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Worker enhancement Request for new feature and/or capability
Projects
None yet
Development

No branches or pull requests

3 participants