-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc][namespaces][C++ worker]add document for c++ worker namespace and specifying namespace while creating/getting named actors #26498
Conversation
@edoakes @ericl @maxpumperla @pcmoritz @richardliaw @simon-mo |
@WangTaoTheTonic You missed DCO. |
Signed-off-by: WangTaoTheTonic <[email protected]>
Signed-off-by: WangTaoTheTonic <[email protected]>
@scv119 please take a look; since this is related to Ray Core documentation |
class Actor: | ||
pass | ||
|
||
ctx = ray.init("ray:https://localhost:10001") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10001 is the ray client port; i believe it's not recommended in python and not supported in Java and C++. this means the Java and CPP code will fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't know it's not recommended in python. I'll change the Java and C++ part first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the address part in C++. For the python part I'd like to keep it consistent with other descriptions in same doc. What do you think? @simon-mo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: WangTaoTheTonic <[email protected]>
Why are these changes needed?
We've supported namespace in c++ worker in #26327. Here we add doc for usage and also reinforce the documents of Java and Python, like adding explanation of specifying namespace while creating named actors.
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.