Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][c++ worker]Add namespace support for c++ worker #26327

Merged
merged 8 commits into from
Jul 12, 2022
Merged

[core][c++ worker]Add namespace support for c++ worker #26327

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
205aa91
Add namespace support for c++ worker
WangTaoTheTonic Jul 6, 2022
28a6e0a
add a simple test
WangTaoTheTonic Jul 6, 2022
1eb5e49
lint
WangTaoTheTonic Jul 7, 2022
9e4ca3b
add getActor(name, namespace) api
WangTaoTheTonic Jul 7, 2022
879f869
lint, comments
WangTaoTheTonic Jul 7, 2022
f760f3b
â€fix test
WangTaoTheTonic Jul 7, 2022
2531048
fix test and add more
WangTaoTheTonic Jul 8, 2022
309bc61
Merge branch 'master' into a_ns
WangTaoTheTonic Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
â�fix test
  • Loading branch information
@WangTaoTheTonic
WangTaoTheTonic committed Jul 7, 2022
commit f760f3b6a55da209e9ec931b003307c4545cec29
4 changes: 3 additions & 1 deletion cpp/src/ray/runtime/abstract_ray_runtime.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,9 @@ PlacementGroup AbstractRayRuntime::GetPlacementGroupById(const std::string &id)
}

PlacementGroup AbstractRayRuntime::GetPlacementGroup(const std::string &name) {
auto str_ptr = global_state_accessor_->GetPlacementGroupByName(name, "");
// TODO(WangTaoTheTonic): Add namespace support for placement group.
auto str_ptr = global_state_accessor_->GetPlacementGroupByName(
name, CoreWorkerProcess::GetCoreWorker().GetJobConfig().ray_namespace());
if (str_ptr == nullptr) {
return {};
}
Expand Down