Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSYS2 install: use MinGW python-qmk package #17302

Merged
merged 4 commits into from
Jul 2, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jun 3, 2022

Description

  • python-qmk package has been added to the MSYS2 repo; updated install script and docs to use it
  • Removed requirements.txt line as those dependencies will now be handled by python-qmk. It might cause conflicts anyway as it still references qmk-dotty-dict which is no longer needed on MSYS2
  • Removed unzip as I couldn't figure out where it was used - possibly left over from the precompiled AVR/ARM toolchains?
  • Added hid-bootloader-cli, mdloader and wb32-dfu-updater for parity with Toolbox

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 3, 2022 22:26
@github-actions github-actions bot added the core label Jun 3, 2022
@fauxpark fauxpark marked this pull request as draft June 4, 2022 12:05
@fauxpark
Copy link
Member Author

fauxpark commented Jun 4, 2022

Getting error while loading shared libraries: MSVCR120.dll: cannot open shared object file: No such file or directory when trying to run qmk --version on a fresh 21H2 VM. Investigating...

@fauxpark fauxpark marked this pull request as ready for review June 7, 2022 14:52
@drashna drashna requested a review from a team June 7, 2022 18:32
@zvecr zvecr merged commit 25033d5 into qmk:master Jul 2, 2022
@fauxpark fauxpark deleted the msys-install-qmk-package branch July 2, 2022 14:27
casuanoob pushed a commit to casuanoob/qmk_firmware that referenced this pull request Jul 2, 2022
* MSYS2 install: use MinGW python-qmk package

* Add missing flashers

* Note VC Redist for manual install

* VC Redist no longer needed
tim-bennett83 pushed a commit to tim-bennett83/qmk_firmware that referenced this pull request Jul 27, 2022
* tag '0.17.5': (117 commits)
  MSYS2 install: use MinGW python-qmk package (qmk#17302)
  My ErgoDox Keymap (finally perfected, I think) (qmk#17208)
  Add BigBoy macro pad (qmk#16962)
  [Keyboard] Add Support to Ducky One2 SF (qmk#17260)
  add rotary encoder support for Quark^2 (qmk#17470)
  [Keyboard]KPrepublic bm80v2 Keyboard ANSI support (qmk#17192)
  add crkbd/keymaps/bermeo (qmk#17320)
  [keyboard] annepro2 Add support for sticky keys (qmk#17359)
  Cleanup post-qmk#17314. (qmk#17536)
  [keymap] Add tiny text, full width characters to Ergodone->Vega (qmk#17427)
  Added 3 new keyboards (qmk#17314)
  feat(keymap): add keebio/iris/rev6/radlinskii keymap (qmk#17216)
  Allow for RGB actions to take place on Keydown instead of Keyup (qmk#16886)
  Add note about qmk doctor in newbs_flashing.md (qmk#15688)
  [Keyboard] New IDOBAO ID63 (a.k.a. Denwir D60) (qmk#17144)
  Added VIA support for Drop CTRL (qmk#17336)
  Add keymaps for muralis and kuru (qmk#17337)
  Swift65 Hotswap Support (qmk#16987)
  Add Jpe230 Preonic Keymap (qmk#17331)
  Add personal YMDK Split64 keymap (qmk#16980)
  ...
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
* MSYS2 install: use MinGW python-qmk package

* Add missing flashers

* Note VC Redist for manual install

* VC Redist no longer needed
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
* MSYS2 install: use MinGW python-qmk package

* Add missing flashers

* Note VC Redist for manual install

* VC Redist no longer needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants