Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Support to Ducky One2 SF #17260

Merged
merged 7 commits into from
Jul 2, 2022
Merged

[Keyboard] Add Support to Ducky One2 SF #17260

merged 7 commits into from
Jul 2, 2022

Conversation

f7urry
Copy link

@f7urry f7urry commented May 31, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@f7urry f7urry requested a review from drashna June 1, 2022 20:02
drashna
drashna requested changes Jun 2, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a 'default' keymap.

@f7urry f7urry requested a review from drashna June 5, 2022 04:18
@drashna drashna requested a review from a team June 7, 2022 22:37
@tzarc tzarc merged commit 81b7d6f into qmk:master Jul 2, 2022
casuanoob pushed a commit to casuanoob/qmk_firmware that referenced this pull request Jul 2, 2022
@f7urry @casuanoob
[Keyboard] Add Support to Ducky One2 SF (qmk#17260)
52c977c
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@f7urry @schattenbrot
[Keyboard] Add Support to Ducky One2 SF (qmk#17260)
76368ca
@ollipasanen ollipasanen mentioned this pull request Aug 3, 2022
Closed
4 tasks
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@f7urry @nolanseaton
[Keyboard] Add Support to Ducky One2 SF (qmk#17260)
4cd1186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f7urry @drashna @tzarc