Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for RGB actions to take place on Keydown instead of Keyup #16886

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Allow for RGB actions to take place on Keydown instead of Keyup #16886

merged 2 commits into from
Jul 2, 2022

Conversation

CoffeeIsLife87
Copy link
Contributor

Adds an #ifdef statement that slightly alters the process_rgb() function allowing for a more responsive feeling RGB subsystem

Description

This adds an #ifdef statement that lets the user apply changes to the currect RGB effect on key press as opposed to key release
This is off by default so that the boards the feature was initially changed for don't break again
the change is enabled by #define RGB_TRIGGER_ON_KEYDOWN being placed in either user or keyboard level config.c

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None that I'm aware of

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@stale
Copy link

stale bot commented Jun 12, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna drashna requested a review from a team June 13, 2022 18:56
@stale stale bot removed the awaiting changes label Jun 13, 2022
fauxpark
fauxpark reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would also apply to RGBLight as well as RGB Matrix.

@tzarc tzarc merged commit 0365f64 into qmk:master Jul 2, 2022
@tzarc
Copy link
Member

tzarc commented Jul 2, 2022

Sigh, this should have targeted develop.

casuanoob pushed a commit to casuanoob/qmk_firmware that referenced this pull request Jul 2, 2022
@CoffeeIsLife87 @casuanoob
Allow for RGB actions to take place on Keydown instead of Keyup (qmk#…
db8fddd 
…16886)

* Allow for switch on keydown

* add docs
tim-bennett83 pushed a commit to tim-bennett83/qmk_firmware that referenced this pull request Jul 27, 2022
Merge tag '0.17.5'
24c1665 
* tag '0.17.5': (117 commits)
  MSYS2 install: use MinGW python-qmk package (qmk#17302)
  My ErgoDox Keymap (finally perfected, I think) (qmk#17208)
  Add BigBoy macro pad (qmk#16962)
  [Keyboard] Add Support to Ducky One2 SF (qmk#17260)
  add rotary encoder support for Quark^2 (qmk#17470)
  [Keyboard]KPrepublic bm80v2 Keyboard ANSI support (qmk#17192)
  add crkbd/keymaps/bermeo (qmk#17320)
  [keyboard] annepro2 Add support for sticky keys (qmk#17359)
  Cleanup post-qmk#17314. (qmk#17536)
  [keymap] Add tiny text, full width characters to Ergodone->Vega (qmk#17427)
  Added 3 new keyboards (qmk#17314)
  feat(keymap): add keebio/iris/rev6/radlinskii keymap (qmk#17216)
  Allow for RGB actions to take place on Keydown instead of Keyup (qmk#16886)
  Add note about qmk doctor in newbs_flashing.md (qmk#15688)
  [Keyboard] New IDOBAO ID63 (a.k.a. Denwir D60) (qmk#17144)
  Added VIA support for Drop CTRL (qmk#17336)
  Add keymaps for muralis and kuru (qmk#17337)
  Swift65 Hotswap Support (qmk#16987)
  Add Jpe230 Preonic Keymap (qmk#17331)
  Add personal YMDK Split64 keymap (qmk#16980)
  ...
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@CoffeeIsLife87 @schattenbrot
Allow for RGB actions to take place on Keydown instead of Keyup (qmk#…
bc1d801 
…16886)

* Allow for switch on keydown

* add docs
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@CoffeeIsLife87 @nolanseaton
Allow for RGB actions to take place on Keydown instead of Keyup (qmk#…
ef4effc 
…16886)

* Allow for switch on keydown

* add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CoffeeIsLife87 @tzarc @drashna @fauxpark