Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add personal YMDK Split64 keymap #16980

Merged
merged 10 commits into from
Jul 2, 2022
Merged

Add personal YMDK Split64 keymap #16980

merged 10 commits into from
Jul 2, 2022

Conversation

minkezhang
Copy link

@minkezhang minkezhang commented May 1, 2022

Description

Add personal YMDK Split64 keymap for minkezhang

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the keymap label May 1, 2022
@drashna drashna added the pr_checklist_pending Needs changes as per the PR checklist label May 3, 2022
@drashna
Copy link
Member

drashna commented May 3, 2022

Please review the PR Checklist document and verify that you have followed the checklist for the type of PR this is.

Namely, c and h files need licensing headers, and filenames should be all lower case.

@minkezhang
Copy link
Author

minkezhang commented May 3, 2022

Done. PR Checklist mentions "GPL-compatible" licenses, but is not explicit on the version. I assume since this implies there is GPLv2 code in the repo, we cannot use Apache2?

I see /ymdk/sp64/config.h is GPLv2, so this is explicitly the case.

@minkezhang
Copy link
Author

@drashna Gentle ping, anything else here that I should be on the lookout for?

keyboards/ymdk/sp64/keymaps/minkezhang/keymap.c Outdated Show resolved Hide resolved
keyboards/ymdk/sp64/keymaps/minkezhang/keymap.c Outdated Show resolved Hide resolved
keyboards/ymdk/sp64/keymaps/minkezhang/keymap.c Outdated Show resolved Hide resolved
keyboards/ymdk/sp64/keymaps/minkezhang/keymap.c Outdated Show resolved Hide resolved
keyboards/ymdk/sp64/keymaps/minkezhang/keymap.c Outdated Show resolved Hide resolved
keyboards/ymdk/sp64/keymaps/minkezhang/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team May 20, 2022 05:15
@minkezhang minkezhang requested a review from drashna May 27, 2022 23:36
@drashna drashna requested a review from a team June 10, 2022 03:50
@drashna drashna removed the pr_checklist_pending Needs changes as per the PR checklist label Jun 10, 2022
@tzarc tzarc merged commit 4a3e0ef into qmk:master Jul 2, 2022
casuanoob pushed a commit to casuanoob/qmk_firmware that referenced this pull request Jul 2, 2022
@minkezhang minkezhang deleted the ymdksp64minkezhang branch July 2, 2022 21:19
tim-bennett83 pushed a commit to tim-bennett83/qmk_firmware that referenced this pull request Jul 27, 2022
* tag '0.17.5': (117 commits)
  MSYS2 install: use MinGW python-qmk package (qmk#17302)
  My ErgoDox Keymap (finally perfected, I think) (qmk#17208)
  Add BigBoy macro pad (qmk#16962)
  [Keyboard] Add Support to Ducky One2 SF (qmk#17260)
  add rotary encoder support for Quark^2 (qmk#17470)
  [Keyboard]KPrepublic bm80v2 Keyboard ANSI support (qmk#17192)
  add crkbd/keymaps/bermeo (qmk#17320)
  [keyboard] annepro2 Add support for sticky keys (qmk#17359)
  Cleanup post-qmk#17314. (qmk#17536)
  [keymap] Add tiny text, full width characters to Ergodone->Vega (qmk#17427)
  Added 3 new keyboards (qmk#17314)
  feat(keymap): add keebio/iris/rev6/radlinskii keymap (qmk#17216)
  Allow for RGB actions to take place on Keydown instead of Keyup (qmk#16886)
  Add note about qmk doctor in newbs_flashing.md (qmk#15688)
  [Keyboard] New IDOBAO ID63 (a.k.a. Denwir D60) (qmk#17144)
  Added VIA support for Drop CTRL (qmk#17336)
  Add keymaps for muralis and kuru (qmk#17337)
  Swift65 Hotswap Support (qmk#16987)
  Add Jpe230 Preonic Keymap (qmk#17331)
  Add personal YMDK Split64 keymap (qmk#16980)
  ...
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants