Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8557] Send caller app name #8570

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[#8557] add okhttp support
  • Loading branch information
yjqg6666 committed Dec 30, 2021
commit c11645b07a41af9f63e89c6968164155f59d6d83
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
import com.navercorp.pinpoint.bootstrap.interceptor.scope.InterceptorScopeInvocation;
import com.navercorp.pinpoint.bootstrap.logging.PLogger;
import com.navercorp.pinpoint.bootstrap.logging.PLoggerFactory;
import com.navercorp.pinpoint.bootstrap.plugin.request.ApplicationInfoSender;
import com.navercorp.pinpoint.bootstrap.plugin.request.ClientHeaderAdaptor;
import com.navercorp.pinpoint.bootstrap.plugin.request.DefaultApplicationInfoSender;
import com.navercorp.pinpoint.bootstrap.plugin.request.DefaultRequestTraceWriter;
import com.navercorp.pinpoint.bootstrap.plugin.request.RequestTraceWriter;
import com.navercorp.pinpoint.plugin.okhttp.v2.RequestBuilder2ClientHeaderAdaptor;
Expand All @@ -42,6 +44,7 @@ public abstract class AbstractRequestBuilderBuildMethodInterceptor implements Ar
protected final MethodDescriptor methodDescriptor;
protected final InterceptorScope interceptorScope;
protected final RequestTraceWriter<Request.Builder> requestTraceWriter;
protected final ApplicationInfoSender<Request.Builder> applicationInfoSender;

public AbstractRequestBuilderBuildMethodInterceptor(TraceContext traceContext, MethodDescriptor methodDescriptor, InterceptorScope interceptorScope) {
this.traceContext = traceContext;
Expand All @@ -50,6 +53,7 @@ public AbstractRequestBuilderBuildMethodInterceptor(TraceContext traceContext, M

ClientHeaderAdaptor<Request.Builder> clientHeaderAdaptor = new RequestBuilder2ClientHeaderAdaptor();
this.requestTraceWriter = new DefaultRequestTraceWriter<>(clientHeaderAdaptor, traceContext);
this.applicationInfoSender = new DefaultApplicationInfoSender<>(clientHeaderAdaptor, traceContext);
}

abstract String toHost(Object target);
Expand All @@ -71,6 +75,8 @@ public void before(Object target, Object[] args) {
}

final Request.Builder builder = ((Request.Builder) target);
applicationInfoSender.sendCallerApplicationName(builder);

if (!trace.canSampled()) {
this.requestTraceWriter.write(builder);
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
import com.navercorp.pinpoint.bootstrap.interceptor.scope.InterceptorScopeInvocation;
import com.navercorp.pinpoint.bootstrap.logging.PLogger;
import com.navercorp.pinpoint.bootstrap.logging.PLoggerFactory;
import com.navercorp.pinpoint.bootstrap.plugin.request.ApplicationInfoSender;
import com.navercorp.pinpoint.bootstrap.plugin.request.ClientHeaderAdaptor;
import com.navercorp.pinpoint.bootstrap.plugin.request.DefaultApplicationInfoSender;
import com.navercorp.pinpoint.bootstrap.plugin.request.DefaultRequestTraceWriter;
import com.navercorp.pinpoint.bootstrap.plugin.request.RequestTraceWriter;
import com.navercorp.pinpoint.common.plugin.util.HostAndPort;
Expand All @@ -46,6 +48,7 @@ public class RequestBuilderBuildMethodInterceptor implements AroundInterceptor {
private final MethodDescriptor methodDescriptor;
private final InterceptorScope interceptorScope;
private final RequestTraceWriter<Request.Builder> requestTraceWriter;;
private final ApplicationInfoSender<Request.Builder> applicationInfoSender;;

public RequestBuilderBuildMethodInterceptor(TraceContext traceContext, MethodDescriptor methodDescriptor, InterceptorScope interceptorScope) {
this.traceContext = traceContext;
Expand All @@ -54,6 +57,7 @@ public RequestBuilderBuildMethodInterceptor(TraceContext traceContext, MethodDes

ClientHeaderAdaptor<Request.Builder> clientHeaderAdaptor = new RequestBuilder3ClientHeaderAdaptor();
this.requestTraceWriter = new DefaultRequestTraceWriter<>(clientHeaderAdaptor, traceContext);
this.applicationInfoSender = new DefaultApplicationInfoSender<>(clientHeaderAdaptor, traceContext);
}

@Override
Expand All @@ -71,7 +75,10 @@ public void before(Object target, Object[] args) {
if (!(target instanceof Request.Builder)) {
return;
}

final Request.Builder builder = ((Request.Builder) target);
applicationInfoSender.sendCallerApplicationName(builder);

if (!trace.canSampled()) {
this.requestTraceWriter.write(builder);
return;
Expand Down