-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8557] Send caller app name #8570
Open
yjqg6666
wants to merge
21
commits into
pinpoint-apm:master
Choose a base branch
from
yjqg6666:send-caller-app-name
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+393
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@emeroad @koo-taejin this feature is completed and tested. PTAL. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8570 +/- ##
============================================
- Coverage 39.79% 39.65% -0.14%
- Complexity 11401 11403 +2
============================================
Files 3350 3363 +13
Lines 89354 89674 +320
Branches 9924 9963 +39
============================================
+ Hits 35555 35557 +2
- Misses 50737 51057 +320
+ Partials 3062 3060 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #8557.
This feature is disabled by default.
It can be enabled by configuration "profiler.sendAppName.enable=true". The header for caller application name can be configured by "profiler.sendAppName.headerName", default to "X-Caller-Application-Name". If you want to have less traffic consumed, you can configure the header to "X-CAN" or "CAN" or "Caller".
It's useful to combine this feature with PR #6987 "record server received request header/cookie" which has been available since version v2.1.0.
Supported http client: