Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8557] Send caller app name #8570

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

yjqg6666
Copy link
Contributor

@yjqg6666 yjqg6666 commented Dec 30, 2021

Resolve #8557.

This feature is disabled by default.

It can be enabled by configuration "profiler.sendAppName.enable=true". The header for caller application name can be configured by "profiler.sendAppName.headerName", default to "X-Caller-Application-Name". If you want to have less traffic consumed, you can configure the header to "X-CAN" or "CAN" or "Caller".

It's useful to combine this feature with PR #6987 "record server received request header/cookie" which has been available since version v2.1.0.

Supported http client:

  • Apache http client 4 (IT updated)
  • Apache http client 3 (IT updated)
  • jdk http url connection (IT updated)
  • ning async http client (IT updated)
  • okhttp (IT updated)
  • reactor-netty
  • webflux
  • vertx

@yjqg6666
Copy link
Contributor Author

yjqg6666 commented Dec 30, 2021

@emeroad @koo-taejin this feature is completed and tested. PTAL.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 39.65%. Comparing base (23c8dc1) to head (6868900).
Report is 1633 commits behind head on master.

Files Patch % Lines
...p/plugin/request/DefaultApplicationInfoSender.java 0.00% 15 Missing ⚠️
...ceptor/HttpMethodBaseExecuteMethodInterceptor.java 0.00% 6 Missing ⚠️
...synchttpclient/interceptor/ExecuteInterceptor.java 0.00% 6 Missing ⚠️
...pclient/interceptor/ExecuteRequestInterceptor.java 0.00% 6 Missing ⚠️
.../AbstractRequestBuilderBuildMethodInterceptor.java 0.00% 5 Missing ⚠️
...erceptor/RequestBuilderBuildMethodInterceptor.java 0.00% 5 Missing ⚠️
...ttp1xClientConnectionCreateRequestInterceptor.java 0.00% 4 Missing ⚠️
...ientExchangeHandlerImplStartMethodInterceptor.java 0.00% 3 Missing ⚠️
...r/HttpRequestExecutorExecuteMethodInterceptor.java 0.00% 3 Missing ⚠️
...nterceptor/HttpClientImplDoRequestInterceptor.java 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #8570      +/-   ##
============================================
- Coverage     39.79%   39.65%   -0.14%     
- Complexity    11401    11403       +2     
============================================
  Files          3350     3363      +13     
  Lines         89354    89674     +320     
  Branches       9924     9963      +39     
============================================
+ Hits          35555    35557       +2     
- Misses        50737    51057     +320     
+ Partials       3062     3060       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yjqg6666 yjqg6666 closed this Mar 9, 2022
@yjqg6666 yjqg6666 reopened this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR.] always send caller application name
1 participant