-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR.] always send caller application name #8557
Comments
It seems that the data you are adding is the same type as
What's the difference with |
This header will always be sent regardless of sampling rate and async running in a different thread. The Pinpoint-pAppName header is only sent when the transaction is sampled and is hidden from application (profiler.tomcat/jetty.hidepinpointheader =true) to get. In most of the use cases, the caller application name is the most valuable, esp. for API statistics (api upgrading/deprecation/ removal). The header name can be configured and the header can be fetched by callee app programmatically. |
It is a bug that AsyncContext works in DisableTrace state.
The intended behavior is that AsyncContext should not work in DisableTrace.
How about adding header api to Agent SDK? Optional<Headers> headers = AgentContext.getHeaders();
if (headers.isPresent()) {
Header header = headers.getParentApplicationName(); // getHeader("Pinpoint-pAppName"")
header.getName();
header.getValue();
} |
@emeroad if the transaction is not traced, you could not know who's calling? |
Which module is your feature request related to?
Plugin
Is your feature request related to a problem?
If the call path is A -> B -> C, B calls C in a different thread(without changing code). The C will have a new transaction trace and will never know who called. On the web side, the calling side is always a virtual node user. If we know which app made the call, we could change the application code to use pinpoint-sdk to wrap the existing code.
Describe the solution you'd like
In the http client plugins, insert a caller application name header to request.
Add a config to enable/disable this feature and a configure for header name.
A new PR would be made.PR
#8561#8570 is made to resolve this issue.The text was updated successfully, but these errors were encountered: