Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8557] Send caller app name #8570

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[#8557] update ning support
  • Loading branch information
yjqg6666 committed Jan 5, 2022
commit 6868900e319778a8b6c37a4fa95735815a80c0bf
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@

ClientHeaderAdaptor<Request> clientHeaderAdaptor = new RequestHeaderAdaptorV2();
this.requestTraceWriter = new DefaultRequestTraceWriter<>(clientHeaderAdaptor, traceContext);
this.applicationInfoSender = new DefaultApplicationInfoSender<>(clientHeaderAdaptor, traceContext);

Check warning on line 81 in plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteInterceptor.java

View check run for this annotation

Codecov / codecov/patch

plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteInterceptor.java#L81

Added line #L81 was not covered by tests
}

@Override
Expand All @@ -87,18 +87,18 @@
logger.beforeInterceptor(target, args);
}

final Trace trace = traceContext.currentRawTraceObject();
if (trace == null) {
return;
}

if (!validate(args)) {
return;
}

final Request httpRequest = (Request) args[0];
applicationInfoSender.sendCallerApplicationName(httpRequest);

Check warning on line 95 in plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteInterceptor.java

View check run for this annotation

Codecov / codecov/patch

plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteInterceptor.java#L94-L95

Added lines #L94 - L95 were not covered by tests

final Trace trace = traceContext.currentRawTraceObject();

Check warning on line 97 in plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteInterceptor.java

View check run for this annotation

Codecov / codecov/patch

plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteInterceptor.java#L97

Added line #L97 was not covered by tests
if (trace == null) {
return;
}

final boolean sampling = trace.canSampled();
if (!sampling) {
if (httpRequest != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@

ClientHeaderAdaptor<Request> clientHeaderAdaptor = new RequestHeaderAdaptorV1();
this.requestTraceWriter = new DefaultRequestTraceWriter<>(clientHeaderAdaptor, traceContext);
this.applicationInfoSender = new DefaultApplicationInfoSender<>(clientHeaderAdaptor, traceContext);

Check warning on line 87 in plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteRequestInterceptor.java

View check run for this annotation

Codecov / codecov/patch

plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteRequestInterceptor.java#L87

Added line #L87 was not covered by tests
}

@Override
Expand All @@ -93,18 +93,18 @@
logger.beforeInterceptor(target, args);
}

final Trace trace = traceContext.currentRawTraceObject();
if (trace == null) {
return;
}

if (!validate(args)) {
return;
}

final Request httpRequest = (Request) args[0];
applicationInfoSender.sendCallerApplicationName(httpRequest);

Check warning on line 101 in plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteRequestInterceptor.java

View check run for this annotation

Codecov / codecov/patch

plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteRequestInterceptor.java#L100-L101

Added lines #L100 - L101 were not covered by tests

final Trace trace = traceContext.currentRawTraceObject();

Check warning on line 103 in plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteRequestInterceptor.java

View check run for this annotation

Codecov / codecov/patch

plugins/ning-asynchttpclient/src/main/java/com/navercorp/pinpoint/plugin/ning/asynchttpclient/interceptor/ExecuteRequestInterceptor.java#L103

Added line #L103 was not covered by tests
if (trace == null) {
return;
}

final boolean sampling = trace.canSampled();
if (!sampling) {
if (httpRequest != null) {
Expand Down
Loading