Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Revert infinite scroll from release 5.8v #2303

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Revert infinite scroll from release 5.8v #2303

merged 3 commits into from
Jan 30, 2019

Conversation

sudheerDev
Copy link
Contributor

Summary

Reverts infinite scroll.
Commits are cherry-picked from #2104 and #2112 as it was done for 5.6v

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed

@sudheerDev
Revert infinite scroll changes
abb833e
@sudheerDev
Fix an error with ScrollToBottomArrows
55d250f 
  * Fix the error of onClick with scrollToBottomArrow prop
@sudheerDev sudheerDev added the 2: Dev Review Requires review by a core commiter label Jan 30, 2019
@sudheerDev sudheerDev added this to the v5.8.0 milestone Jan 30, 2019
@sudheerDev
Copy link
Contributor Author

Build fails going trough the cherry-pick again

@sudheerDev
Copy link
Contributor Author

Needed to remove variables added in from #2079. Good to go

@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed 2: Dev Review Requires review by a core commiter labels Jan 30, 2019
@sudheerDev sudheerDev merged commit 57c60d8 into mattermost:release-5.8 Jan 30, 2019
@sudheerDev sudheerDev deleted the revert/autoScroll branch January 30, 2019 19:27
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 31, 2019
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Feb 13, 2019
sudheerDev added a commit to sudheerDev/mattermost-webapp that referenced this pull request Apr 5, 2019
@sudheerDev
Revert infinite scroll from release 5.8v (mattermost#2303)
07655ba 
* Revert infinite scroll changes

* Fix an error with ScrollToBottomArrows

  * Fix the error of onClick with scrollToBottomArrow prop

* Remove unused variables
sudheerDev added a commit to sudheerDev/mattermost-webapp that referenced this pull request Apr 5, 2019
@sudheerDev
Revert infinite scroll from release 5.8v (mattermost#2303)
bc1753c 
* Revert infinite scroll changes

* Fix an error with ScrollToBottomArrows

  * Fix the error of onClick with scrollToBottomArrow prop

* Remove unused variables
@sudheerDev sudheerDev mentioned this pull request Apr 5, 2019
Merged
sudheerDev added a commit that referenced this pull request Apr 8, 2019
@sudheerDev
Revert virtualised and auto load of posts (#2622)
ac1cafe 
* Revert "MM-14810 Fix for channel header loading in center channel (#2596)"

This reverts commit 6bc18af.

* Revert "MM-14761 Loading channel with lot of unreads should show loader at the top (#2589)"

This reverts commit 3e88c52.

* Revert "MM-14810 Fix for infinite loop caused by loading channels with content less than screen height (#2572)"

This reverts commit b11b42c.

* Revert "Expose virt list scroll variables to window (#2569)"

This reverts commit 4e7715a.

* Revert "MM-14820 Fix post menu on mobile view (#2576)"

This reverts commit 8bd8dda.

* Revert "Fix postlist connector when channel is undefined (#2573)"

This reverts commit 03177f2.

* Revert "MM-14800 Fix missing messages when switching to a team not previously loaded (#2562)"

This reverts commit 3537b03.

* Revert "MM-14196 Add virtualised list for posts (#2447)"

This reverts commit ec5c279.

* Revert infinite scroll from release 5.8v (#2303)

* Revert infinite scroll changes

* Fix an error with ScrollToBottomArrows

  * Fix the error of onClick with scrollToBottomArrow prop

* Remove unused variables
bradjcoughlin pushed a commit to bradjcoughlin/mattermost-webapp that referenced this pull request Apr 15, 2019
@sudheerDev @bradjcoughlin
Revert virtualised and auto load of posts (mattermost#2622)
6b67e60 
* Revert "MM-14810 Fix for channel header loading in center channel (mattermost#2596)"

This reverts commit 6bc18af.

* Revert "MM-14761 Loading channel with lot of unreads should show loader at the top (mattermost#2589)"

This reverts commit 3e88c52.

* Revert "MM-14810 Fix for infinite loop caused by loading channels with content less than screen height (mattermost#2572)"

This reverts commit b11b42c.

* Revert "Expose virt list scroll variables to window (mattermost#2569)"

This reverts commit 4e7715a.

* Revert "MM-14820 Fix post menu on mobile view (mattermost#2576)"

This reverts commit 8bd8dda.

* Revert "Fix postlist connector when channel is undefined (mattermost#2573)"

This reverts commit 03177f2.

* Revert "MM-14800 Fix missing messages when switching to a team not previously loaded (mattermost#2562)"

This reverts commit 3537b03.

* Revert "MM-14196 Add virtualised list for posts (mattermost#2447)"

This reverts commit ec5c279.

* Revert infinite scroll from release 5.8v (mattermost#2303)

* Revert infinite scroll changes

* Fix an error with ScrollToBottomArrows

  * Fix the error of onClick with scrollToBottomArrow prop

* Remove unused variables
tuannguyen041094 pushed a commit to Designveloper/mattermost-webapp that referenced this pull request Apr 21, 2019
@sudheerDev @tuannguyen041094
Revert infinite scroll from release 5.8v (mattermost#2303)
d062871 
* Revert infinite scroll changes

* Fix an error with ScrollToBottomArrows

  * Fix the error of onClick with scrollToBottomArrow prop

* Remove unused variables
TranMacTien pushed a commit to Designveloper/mattermost-webapp that referenced this pull request Jun 13, 2019
@sudheerDev @TranMacTien
Revert virtualised and auto load of posts (mattermost#2622)
6d0f270 
* Revert "MM-14810 Fix for channel header loading in center channel (mattermost#2596)"

This reverts commit 6bc18af.

* Revert "MM-14761 Loading channel with lot of unreads should show loader at the top (mattermost#2589)"

This reverts commit 3e88c52.

* Revert "MM-14810 Fix for infinite loop caused by loading channels with content less than screen height (mattermost#2572)"

This reverts commit b11b42c.

* Revert "Expose virt list scroll variables to window (mattermost#2569)"

This reverts commit 4e7715a.

* Revert "MM-14820 Fix post menu on mobile view (mattermost#2576)"

This reverts commit 8bd8dda.

* Revert "Fix postlist connector when channel is undefined (mattermost#2573)"

This reverts commit 03177f2.

* Revert "MM-14800 Fix missing messages when switching to a team not previously loaded (mattermost#2562)"

This reverts commit 3537b03.

* Revert "MM-14196 Add virtualised list for posts (mattermost#2447)"

This reverts commit ec5c279.

* Revert infinite scroll from release 5.8v (mattermost#2303)

* Revert infinite scroll changes

* Fix an error with ScrollToBottomArrows

  * Fix the error of onClick with scrollToBottomArrow prop

* Remove unused variables
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saturninoabril saturninoabril saturninoabril approved these changes

@enahum enahum enahum approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sudheerDev @saturninoabril @enahum @lindalumitchell @amyblais