This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-13180 Call load posts earlier for infinite scroll #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@esethna would you like to test on a spin mint? |
sudheerDev
added
the
Setup Old Test Server
enahum
approved these changes
Nov 26, 2018
saturninoabril
approved these changes
Nov 27, 2018
saturninoabril
added
4: Reviews Complete
esethna
approved these changes
Nov 27, 2018
sudheerDev
added
Awaiting Submitter Action
sudheerDev
added
the
Setup Old Test Server
sudheerDev
added
Setup Old Test Server
sudheerDev
added
Setup Old Test Server
sudheerDev
added
the
Setup Old Test Server
|
|
|
Spinmint test server created at: https://i-07d1888c53b6bedeb.test.spinmint.com Test Admin Account: Username: Test User Account: Username: Instance ID: i-07d1888c53b6bedeb |
esethna
approved these changes
Dec 20, 2018
esethna
removed
Awaiting Submitter Action
|
Spinmint test server destroyed |
esethna
added
the
4: Reviews Complete
|
Can this be merged now or do we need to wait for the perf improvements to go in forst? |
esethna
added
the
Do Not Merge/Awaiting PR
|
@esethna This is not blocked IMO and better we have this in master for comparing perf benefits from the other PR's |
sudheerDev
removed
the
Do Not Merge/Awaiting PR
lindy65
removed
the
4: Reviews Complete
amyblais
added
Changelog/Not Needed
2 tasks
tuannguyen041094
pushed a commit
to Designveloper/mattermost-webapp
that referenced
this pull request
Apr 24, 2019
* MM-13180 Call load posts earlier for infinite scroll
* Add check for max height for loading posts
* Fix issue of loading posts not getting triggered at right position
when lot of posts are loaded
* scrollHeightAoveFoldForLoad can be really high when lot of posts are loaded
comaparision with max value should be with scrollTop value
* Change the max-value of sctollTop to 2500 for triggering loadPosts
TranMacTien
pushed a commit
to Designveloper/mattermost-webapp
that referenced
this pull request
Jun 13, 2019
* MM-13180 Call load posts earlier for infinite scroll
* Add check for max height for loading posts
* Fix issue of loading posts not getting triggered at right position
when lot of posts are loaded
* scrollHeightAoveFoldForLoad can be really high when lot of posts are loaded
comaparision with max value should be with scrollTop value
* Change the max-value of sctollTop to 2500 for triggering loadPosts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Loads posts earlier than existing trigger.
Existing trigger is at 40% of clientHeight(visible scroll area) so typically about
0.4 * 800(clientHeight)i.e200pxfrom the top of the postList. If there are4000pxof posts in total at present we trigger to load posts when user reaches to3800pxWith this PR we change this to load when scroll position is at 30% from the top. i.e if
4000pxwe trigger to load posts at3040px. i.e by0.3 * (4000 - 800)i.e960pxTicket Link
MM-13180
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed