This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14820 Fix post menu on mobile view #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
added
2: Dev Review
deanwhillier
approved these changes
Apr 1, 2019
sudheerDev
added
4: Reviews Complete
enahum
added a commit
that referenced
this pull request
Apr 2, 2019
enahum
added
CherryPick/Done
thekiiingbob
pushed a commit
to thekiiingbob/mattermost-webapp
that referenced
this pull request
Apr 2, 2019
amyblais
added
Changelog/Not Needed
sudheerDev
added a commit
to sudheerDev/mattermost-webapp
that referenced
this pull request
Apr 5, 2019
This reverts commit 8bd8dda.
sudheerDev
added a commit
that referenced
this pull request
Apr 8, 2019
* Revert "MM-14810 Fix for channel header loading in center channel (#2596)" This reverts commit 6bc18af. * Revert "MM-14761 Loading channel with lot of unreads should show loader at the top (#2589)" This reverts commit 3e88c52. * Revert "MM-14810 Fix for infinite loop caused by loading channels with content less than screen height (#2572)" This reverts commit b11b42c. * Revert "Expose virt list scroll variables to window (#2569)" This reverts commit 4e7715a. * Revert "MM-14820 Fix post menu on mobile view (#2576)" This reverts commit 8bd8dda. * Revert "Fix postlist connector when channel is undefined (#2573)" This reverts commit 03177f2. * Revert "MM-14800 Fix missing messages when switching to a team not previously loaded (#2562)" This reverts commit 3537b03. * Revert "MM-14196 Add virtualised list for posts (#2447)" This reverts commit ec5c279. * Revert infinite scroll from release 5.8v (#2303) * Revert infinite scroll changes * Fix an error with ScrollToBottomArrows * Fix the error of onClick with scrollToBottomArrow prop * Remove unused variables
bradjcoughlin
pushed a commit
to bradjcoughlin/mattermost-webapp
that referenced
this pull request
Apr 15, 2019
* Revert "MM-14810 Fix for channel header loading in center channel (mattermost#2596)" This reverts commit 6bc18af. * Revert "MM-14761 Loading channel with lot of unreads should show loader at the top (mattermost#2589)" This reverts commit 3e88c52. * Revert "MM-14810 Fix for infinite loop caused by loading channels with content less than screen height (mattermost#2572)" This reverts commit b11b42c. * Revert "Expose virt list scroll variables to window (mattermost#2569)" This reverts commit 4e7715a. * Revert "MM-14820 Fix post menu on mobile view (mattermost#2576)" This reverts commit 8bd8dda. * Revert "Fix postlist connector when channel is undefined (mattermost#2573)" This reverts commit 03177f2. * Revert "MM-14800 Fix missing messages when switching to a team not previously loaded (mattermost#2562)" This reverts commit 3537b03. * Revert "MM-14196 Add virtualised list for posts (mattermost#2447)" This reverts commit ec5c279. * Revert infinite scroll from release 5.8v (mattermost#2303) * Revert infinite scroll changes * Fix an error with ScrollToBottomArrows * Fix the error of onClick with scrollToBottomArrow prop * Remove unused variables
TranMacTien
pushed a commit
to Designveloper/mattermost-webapp
that referenced
this pull request
Jun 13, 2019
* Revert "MM-14810 Fix for channel header loading in center channel (mattermost#2596)" This reverts commit 6bc18af. * Revert "MM-14761 Loading channel with lot of unreads should show loader at the top (mattermost#2589)" This reverts commit 3e88c52. * Revert "MM-14810 Fix for infinite loop caused by loading channels with content less than screen height (mattermost#2572)" This reverts commit b11b42c. * Revert "Expose virt list scroll variables to window (mattermost#2569)" This reverts commit 4e7715a. * Revert "MM-14820 Fix post menu on mobile view (mattermost#2576)" This reverts commit 8bd8dda. * Revert "Fix postlist connector when channel is undefined (mattermost#2573)" This reverts commit 03177f2. * Revert "MM-14800 Fix missing messages when switching to a team not previously loaded (mattermost#2562)" This reverts commit 3537b03. * Revert "MM-14196 Add virtualised list for posts (mattermost#2447)" This reverts commit ec5c279. * Revert infinite scroll from release 5.8v (mattermost#2303) * Revert infinite scroll changes * Fix an error with ScrollToBottomArrows * Fix the error of onClick with scrollToBottomArrow prop * Remove unused variables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the implementation of virtualized list the position of the post menu in mobile view was incorrect cause of a css style will-change. With this PR when in mobile view the value of
will-changeis set according to the menu being opened or closed.Also triggering the close event on the MenuWrapper only if the menu was previously opened.
Ticket Link
https://mattermost.atlassian.net/browse/MM-14820