Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14800 Fix missing messages when switching to a team not previously loaded #2562

Merged
merged 3 commits into from
Mar 29, 2019
Merged

MM-14800 Fix missing messages when switching to a team not previously loaded #2562

merged 3 commits into from
Mar 29, 2019

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Mar 28, 2019

Summary

With the recent changes for the virtualized list we added a gate to identify if the channel was being loaded but there was a case when you switched teams when you were viewing a DM channel previously and that flag was never set correctly as the team was selected before the new channel got selected, thus the channel was never marked as being loaded causing the switch not to load the first set of posts in the channel.

Ticket Link

https://mattermost.atlassian.net/browse/MM-14800

@enahum enahum added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Mar 28, 2019
@enahum enahum added this to the v5.10.0 milestone Mar 28, 2019
@enahum enahum requested a review from sudheerDev March 28, 2019 23:26
enahum
enahum commented Mar 28, 2019
View reviewed changes
components/post_view/post_list.jsx
@@ -260,7 +262,7 @@ export default class PostList extends React.PureComponent {
}
} else {
this.loadingPosts = false;
if (this.mounted) {
if (this.mounted && this.props.posts) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the selector to get the posts can return null so the next line was causing an error

@saturninoabril saturninoabril merged commit e3f9aaa into master Mar 29, 2019
@saturninoabril saturninoabril deleted the MM-14800 branch March 29, 2019 09:31
saturninoabril pushed a commit that referenced this pull request Mar 29, 2019
@enahum @saturninoabril
MM-14800 Fix missing messages when switching to a team not previously…
3537b03 
… loaded (#2562)

* Check that this.props.posts is not null when loading more posts

* Fix isChannelLoading to prevent race condition while switching teams

* Remove unnecesary variable
@saturninoabril saturninoabril added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Mar 29, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 29, 2019
stevepartridge pushed a commit to stevepartridge/mattermost-webapp that referenced this pull request Mar 30, 2019
@enahum @stevepartridge
MM-14800 Fix missing messages when switching to a team not previously…
2994d83 
… loaded (mattermost#2562)

* Check that this.props.posts is not null when loading more posts

* Fix isChannelLoading to prevent race condition while switching teams

* Remove unnecesary variable
thekiiingbob pushed a commit to thekiiingbob/mattermost-webapp that referenced this pull request Apr 2, 2019
@enahum @thekiiingbob
MM-14800 Fix missing messages when switching to a team not previously…
6a4afb4 
… loaded (mattermost#2562)

* Check that this.props.posts is not null when loading more posts

* Fix isChannelLoading to prevent race condition while switching teams

* Remove unnecesary variable
sudheerDev added a commit to sudheerDev/mattermost-webapp that referenced this pull request Apr 5, 2019
@sudheerDev
Revert "MM-14800 Fix missing messages when switching to a team not pr…
82b8b36 
…eviously loaded (mattermost#2562)"

This reverts commit 3537b03.
@sudheerDev sudheerDev mentioned this pull request Apr 5, 2019
Merged
sudheerDev added a commit that referenced this pull request Apr 8, 2019
@sudheerDev
Revert virtualised and auto load of posts (#2622)
ac1cafe 
* Revert "MM-14810 Fix for channel header loading in center channel (#2596)"

This reverts commit 6bc18af.

* Revert "MM-14761 Loading channel with lot of unreads should show loader at the top (#2589)"

This reverts commit 3e88c52.

* Revert "MM-14810 Fix for infinite loop caused by loading channels with content less than screen height (#2572)"

This reverts commit b11b42c.

* Revert "Expose virt list scroll variables to window (#2569)"

This reverts commit 4e7715a.

* Revert "MM-14820 Fix post menu on mobile view (#2576)"

This reverts commit 8bd8dda.

* Revert "Fix postlist connector when channel is undefined (#2573)"

This reverts commit 03177f2.

* Revert "MM-14800 Fix missing messages when switching to a team not previously loaded (#2562)"

This reverts commit 3537b03.

* Revert "MM-14196 Add virtualised list for posts (#2447)"

This reverts commit ec5c279.

* Revert infinite scroll from release 5.8v (#2303)

* Revert infinite scroll changes

* Fix an error with ScrollToBottomArrows

  * Fix the error of onClick with scrollToBottomArrow prop

* Remove unused variables
@lindy65 lindy65 modified the milestones: v5.10.0, v5.12.0 Apr 13, 2019
bradjcoughlin pushed a commit to bradjcoughlin/mattermost-webapp that referenced this pull request Apr 15, 2019
@sudheerDev @bradjcoughlin
Revert virtualised and auto load of posts (mattermost#2622)
6b67e60 
* Revert "MM-14810 Fix for channel header loading in center channel (mattermost#2596)"

This reverts commit 6bc18af.

* Revert "MM-14761 Loading channel with lot of unreads should show loader at the top (mattermost#2589)"

This reverts commit 3e88c52.

* Revert "MM-14810 Fix for infinite loop caused by loading channels with content less than screen height (mattermost#2572)"

This reverts commit b11b42c.

* Revert "Expose virt list scroll variables to window (mattermost#2569)"

This reverts commit 4e7715a.

* Revert "MM-14820 Fix post menu on mobile view (mattermost#2576)"

This reverts commit 8bd8dda.

* Revert "Fix postlist connector when channel is undefined (mattermost#2573)"

This reverts commit 03177f2.

* Revert "MM-14800 Fix missing messages when switching to a team not previously loaded (mattermost#2562)"

This reverts commit 3537b03.

* Revert "MM-14196 Add virtualised list for posts (mattermost#2447)"

This reverts commit ec5c279.

* Revert infinite scroll from release 5.8v (mattermost#2303)

* Revert infinite scroll changes

* Fix an error with ScrollToBottomArrows

  * Fix the error of onClick with scrollToBottomArrow prop

* Remove unused variables
@ogi-m ogi-m added the Tests/Done Release tests have been written label May 31, 2019
TranMacTien pushed a commit to Designveloper/mattermost-webapp that referenced this pull request Jun 13, 2019
@sudheerDev @TranMacTien
Revert virtualised and auto load of posts (mattermost#2622)
6d0f270 
* Revert "MM-14810 Fix for channel header loading in center channel (mattermost#2596)"

This reverts commit 6bc18af.

* Revert "MM-14761 Loading channel with lot of unreads should show loader at the top (mattermost#2589)"

This reverts commit 3e88c52.

* Revert "MM-14810 Fix for infinite loop caused by loading channels with content less than screen height (mattermost#2572)"

This reverts commit b11b42c.

* Revert "Expose virt list scroll variables to window (mattermost#2569)"

This reverts commit 4e7715a.

* Revert "MM-14820 Fix post menu on mobile view (mattermost#2576)"

This reverts commit 8bd8dda.

* Revert "Fix postlist connector when channel is undefined (mattermost#2573)"

This reverts commit 03177f2.

* Revert "MM-14800 Fix missing messages when switching to a team not previously loaded (mattermost#2562)"

This reverts commit 3537b03.

* Revert "MM-14196 Add virtualised list for posts (mattermost#2447)"

This reverts commit ec5c279.

* Revert infinite scroll from release 5.8v (mattermost#2303)

* Revert infinite scroll changes

* Fix an error with ScrollToBottomArrows

  * Fix the error of onClick with scrollToBottomArrow prop

* Remove unused variables
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sudheerDev sudheerDev sudheerDev approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.12.0
6 participants
@enahum @sudheerDev @saturninoabril @lindy65 @ogi-m @amyblais