-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search by words option for Channels/Movies/Series #65
Comments
Hey @hect-dpr I was looking for this exact feature and was really happy to see that someone got a start on it. If possible, could you please submit this as a pull request (by creating your own fork first, making the change there, and then opening a pull request against the master branch here [I see no develop branch]) so that I can try out + work on these changes too? I tried opening the PR myself with the diff you pasted but there's a part in your comment that doesn't line up with what I'm seeing in my source (master branch, pulled today). Thanks! |
Here you go @dilutedh2o for active_provider.channels: https://github.com/hect-dpr/hypnotix/tree/dev. I don't think its mature and general enough for a PR. |
This search option for movies and series is very interesting and would be a very useful function |
@clefebvre Great to have IPTV on Mint in a simple application. IMHO a search box should be there. |
@lulol dude you are a hero, that works really well I'm not a maintainer but that has my +1 |
Actually I just found a bug 😟 If you search something, then clear the search bar and hit enter the UI stops reacting |
Hmmm. @dilutedh2o I found that problem before but added a check in There is an explicit check in L532 for an empty search box. But seems that it may not be enough.
But with this check in place I've tried several times to trigger this condition on my system and I'm unable to reproduce the problem. Don't know how you managed to skip the empty string test, and not sure what the root cause is. EDIT: BTW the credit goes to @hect-dpr that is who wrote the original patch. I only adapted it and enhanced the text match. |
May be removing any leading/trailing whitespace from the search text could help. For very large playlists may look that the ui has frozen if the search string is just a space since for some reason seems that it takes a long time to rebuild a list with (almost) all of the channels. |
* Add search box is toggled with seach button * Add Search is a toggle button * Add Search is a toggle button * Add shortcut for search box * Rename on_search_button function for consistency * Fix find menu iten icon * Avoid repeating searches This is to minimize the chance of an issue first [reported](#65 (comment)) by @dilutedh2o for huge lists. Triggering multiple searches before the channels FlowBox rendering is completed may result in Hypnotix being unresponsive for several minutes. Also CTRL-C doesn't work. Have not been able to trace the root cause. May be related to network failures of pending channel logo downloads flooding the home router dropping traffic? * Add Search box grayed out while filtering * Change channel search method Use Gtk.FlowBox.set_filter_func() instead of destroying and recreating Gtk.FlowBox childs. * Fix headerbar AttributeError searching mixed content lists * Avoid race condition playing local content # https://github.com/jaseg/python-mpv#pygobject-embedding # Must be created >after< the widget is shown, else property 'window' will be None Wait for window to get ready before retrieving properties and playing content to avoid it to fail with local content. * Add files via upload * Add files via upload * Add files via upload * Stop waiting for widget window when there are pending events
* Add search box is toggled with seach button * Add Search is a toggle button * Add Search is a toggle button * Add shortcut for search box * Rename on_search_button function for consistency * Fix find menu iten icon * Avoid repeating searches This is to minimize the chance of an issue first [reported](#65 (comment)) by @dilutedh2o for huge lists. Triggering multiple searches before the channels FlowBox rendering is completed may result in Hypnotix being unresponsive for several minutes. Also CTRL-C doesn't work. Have not been able to trace the root cause. May be related to network failures of pending channel logo downloads flooding the home router dropping traffic? * Add Search box grayed out while filtering * Change channel search method Use Gtk.FlowBox.set_filter_func() instead of destroying and recreating Gtk.FlowBox childs. * Fix headerbar AttributeError searching mixed content lists
So, I'm quite a noob in terms of Linux.. How do I add this search bar to Hypnotix? |
@dreizweins The search function is already available since version 2.1 and instalable from the LM repos. The .deb 1.1 release available on Github for download is obsolete. If you are using other linux distro or a not so recent LM, I'm afraid that you may need to download the zip and install the files manually. |
how do i install the files manually? :D |
Hi, I have v3.2 installed. |
Hey @clefebvre,
Great App. Would be better if a quick search channel option across categories is present, so that we can quickly search and find the right available channel. Similarly for movies, VOD etc.
Here's an immature attempt for current active_provider channels:
Thanks
The text was updated successfully, but these errors were encountered: