Add a basic global search box #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works well and it's badly needed :) I don't like the way it's in the headerbar. I would prefer a toggle search button in the headerbar which would reveal a toolbar with the search field underneath instead. I'm merging as is though since we're far away from the release and it's working well. Thanks for this PR. |
|
Agreed. It looked ugly and was a bit confusing. Just left the GtkSearchEntry as suggested by @Axel-Erfurt because with it had the added functionality of the clear button that is useful. Have added code to toggle the search box visibility and is hidden by default. #165 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic global search box for current active_provider channels adapted from @hect-dpr #65
Search text should be now case and diacritic insensitive.