Avoid race condition playing local content #172
Conversation
This is to minimize the chance of an issue first [reported](#65 (comment)) by @dilutedh2o for huge lists. Triggering multiple searches before the channels FlowBox rendering is completed may result in Hypnotix being unresponsive for several minutes. Also CTRL-C doesn't work. Have not been able to trace the root cause. May be related to network failures of pending channel logo downloads flooding the home router dropping traffic?
Use Gtk.FlowBox.set_filter_func() instead of destroying and recreating Gtk.FlowBox childs.
# https://github.com/jaseg/python-mpv#pygobject-embedding # Must be created >after< the widget is shown, else property 'window' will be None Wait for window to get ready before retrieving properties and playing content to avoid it to fail with local content.
|
*Urgh* Sorry for the mess. Hope you squash all these commits. :( |
|
I like the idea, but that is a dangerous loop that could never end. Maybe adding a simple counter up to a value in seconds will guarantee that the wait is no longer than N seconds. Also, just throwing ideas here, it would be nice to show that the process is waiting in the loop by maybe temporarily change the box color around the MPV window or some other visual indications. |
|
You are right. Added a Already had tried calling the main gtk loop after the sleep with The UI already shows a spinner in the widget window before mpv tries to start displaying the content before the window is created. But I guess that you always can press the back button and try again like sometimes is needed now without this patch. |
Wait for window to get ready before retrieving properties and playing content to avoid failures with local content.