Use new webView data source in prod

[nelsitoPuglisi]

Goal

Track web view urls as span events of the session span instead of breadcrumbs.

Testing

Unit test, Integration test and manual test.

[nelsitoPuglisi]

• New ViewDataSource #717
• New PushNotificationDataSource #688
• Use new webView data source in prod #680 👈
• DataSourceModule providers #712
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nelsitoPuglisi and the rest of your teammates on Graphite

[fractalwrench]

Looks good barring one inline comment. I'd also like to confirm that this has been tested E2E before this gets merged.

It would be good to write an integration test too that checks the feature.

[nelsitoPuglisi]

Looks good barring one inline comment. I'd also like to confirm that this has been tested E2E before this gets merged.

It would be good to write an integration test too that checks the feature.

Yes, I tested it manually and checked the json received in the backend, and the dashboard displays it properly.

Besides that, this integration test covers the funcionality https://github.com/embrace-io/embrace-android-sdk/pull/680/files#diff-49417e80327f621fcf052fcad356035ea38339cb3faba2de6bc3242ae5c81e25R120

[bidetofevil]

Why do we need to add this here? Shouldn't the integration test be testing the API by going through Embrace.java in the test?

[nelsitoPuglisi]

There is no public api to track web view URL, it's captured through the swazzler hook.

[codecov]

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.77%. Comparing base (64ddfe4) to head (e384707).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
- Coverage   79.82%   79.77%   -0.05%     
==========================================
  Files         429      429              
  Lines       11328    11330       +2     
  Branches     1719     1720       +1     
==========================================
- Hits         9043     9039       -4     
- Misses       1554     1563       +9     
+ Partials      731      728       -3     

Files	Coverage Δ
.../embracesdk/capture/crumbs/BreadcrumbsSanitizer.kt	100.00% <100.00%> (ø)
...e/android/embracesdk/injection/DataSourceModule.kt	100.00% <100.00%> (ø)
.../embrace/android/embracesdk/payload/Breadcrumbs.kt	100.00% <ø> (ø)
...racesdk/capture/crumbs/EmbraceBreadcrumbService.kt	82.97% <50.00%> (-2.74%)	⬇️
...embrace/android/embracesdk/gating/SpanSanitizer.kt	82.75% <33.33%> (-2.43%)	⬇️

... and 5 files with indirect coverage changes

[fractalwrench]

LGTM