DataSourceModule providers #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @nelsitoPuglisi and the rest of your teammates on |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #712 +/- ##
==========================================
- Coverage 80.40% 80.31% -0.10%
==========================================
Files 426 426
Lines 11274 11270 -4
Branches 1703 1708 +5
==========================================
- Hits 9065 9051 -14
- Misses 1487 1492 +5
- Partials 722 727 +5
|
This was referenced Apr 13, 2024
Merged
bidetofevil
reviewed
Apr 14, 2024
| @@ -108,7 +110,8 @@ internal class IntegrationTestRule( | |||
| workerThreadModuleSupplier = { _ -> workerThreadModule }, | |||
| storageModuleSupplier = { _, _, _ -> storageModule }, | |||
| essentialServiceModuleSupplier = { _, _, _, _, _, _, _, _, _ -> essentialServiceModule }, | |||
| dataCaptureServiceModuleSupplier = { _, _, _, _, _, _, _ -> dataCaptureServiceModule }, | |||
| dataSourceModuleSupplier = { _, _, _, _, _, _ -> dataSourceModule }, | |||
There was a problem hiding this comment.
I tweaked how this works in #716 but I'll rebase off this to make sure your tests still pass
bidetofevil
reviewed
Apr 14, 2024
| sessionSpanWriter: SessionSpanWriter, | ||
| spanService: SpanService, | ||
| private val logger: InternalEmbraceLogger | ||
| private val dataSourceModuleProvider: Provider<DataSourceModule?>, |
There was a problem hiding this comment.
As discussed, because you reordered the module init, you shouldn't need a provider here. But lets merge it and we can fix it later.
nelsitoPuglisi
force-pushed
the
nelson/inject-data-sources
branch
from
32c8d54
to
621086a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Using DataSourceModule to provide data sources to services.
Testing
Unit and Integration