New ViewDataSource

[nelsitoPuglisi]

Goal

The purpose is to capture view navigation as spans instead of breadcrumbs. We have joined views logged manually through the public API, and automatically captured views, like Activities.

Testing

Unit, Integration and Manual test

[nelsitoPuglisi]

• New ViewDataSource #717 👈
• New PushNotificationDataSource #688
• Use new webView data source in prod #680
• DataSourceModule providers #712
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nelsitoPuglisi and the rest of your teammates on Graphite

[bidetofevil]

@fractalwrench is it guaranteed that that activityLifecycleListners will fire before the ProcessLifecycleListeners if both have onStop() listeners registered? We require the view span to end before the session can be stopped, so we need to ensure there's no race condition between to listener calls so the order can be guaranteed,

[fractalwrench]

Interesting question! registerActivityLifecycleCallbacks uses an ArrayList internally, and the docs for ProcessLifecycleOwner state the callback gets added via codegen or reflection. My assumption is that whatever class gets instantiated first will get called first. I'd assume that EmbraceProcessStateService gets instantiated first.

[fractalwrench]

LGTM

[fractalwrench]

This can be deleted as we've removed the ability to set the payload from this

[codecov]

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.66%. Comparing base (b09b5ea) to head (03b2955).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   80.19%   80.66%   +0.47%     
==========================================
  Files         429      423       -6     
  Lines       11374    11260     -114     
  Branches     1725     1703      -22     
==========================================
- Hits         9121     9083      -38     
+ Misses       1532     1458      -74     
+ Partials      721      719       -2     

Files	Coverage Δ
...ndroid/embracesdk/gating/SessionSanitizerFacade.kt	100.00% <ø> (ø)
...d/embracesdk/injection/DataCaptureServiceModule.kt	98.41% <ø> (-0.03%)	⬇️
...e/android/embracesdk/injection/DataSourceModule.kt	100.00% <100.00%> (ø)
...race/android/embracesdk/injection/SessionModule.kt	100.00% <100.00%> (ø)
.../embrace/android/embracesdk/payload/Breadcrumbs.kt	100.00% <100.00%> (ø)
...ssion/orchestrator/OrchestratorBoundaryDelegate.kt	75.00% <ø> (-2.78%)	⬇️
...ndroid/embracesdk/capture/crumbs/ViewDataSource.kt	81.25% <81.81%> (ø)
...racesdk/capture/crumbs/EmbraceBreadcrumbService.kt	66.66% <0.00%> (-13.34%)	⬇️

... and 4 files with indirect coverage changes