WebViewUrlDataSource created

[nelsitoPuglisi]

Goal

Create a DataSource that store WebView urls as SessionSpan events

Testing

Unit tests

[nelsitoPuglisi]

• Use new webView data source in prod #680
• WebViewUrlDataSource created #674 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nelsitoPuglisi and the rest of your teammates on Graphite

[fractalwrench]

LGTM. To consider the feature complete I think it's necessary to create an integration test (see BreadcrumbFeatureTest for an example) and also to update DataSourceModule so this class gets instantiated. I'm assuming that will go ahead in a separate PR

[fractalwrench]

The call to isWebViewBreadcrumbCaptureEnabled can be avoided here - we can follow the pattern for supplying a configGate parameter that other data sources use in DataSourceModule.

[nelsitoPuglisi]

LGTM. To consider the feature complete I think it's necessary to create an integration test (see BreadcrumbFeatureTest for an example) and also to update DataSourceModule so this class gets instantiated. I'm assuming that will go ahead in a separate PR

Yes, those test will be part of the PR that puts this into production.

[codecov]

Codecov Report

Attention: Patch coverage is 81.08108% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 80.16%. Comparing base (5e7a0f0) to head (8479065).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
+ Coverage   80.09%   80.16%   +0.06%     
==========================================
  Files         421      422       +1     
  Lines       11002    11034      +32     
  Branches     1666     1672       +6     
==========================================
+ Hits         8812     8845      +33     
+ Misses       1508     1505       -3     
- Partials      682      684       +2     

Files	Coverage Δ
.../embrace/android/embracesdk/arch/schema/EmbType.kt	86.66% <100.00%> (+0.95%)	⬆️
...brace/android/embracesdk/arch/schema/SchemaType.kt	97.72% <100.00%> (+0.42%)	⬆️
...racesdk/capture/crumbs/EmbraceBreadcrumbService.kt	96.42% <100.00%> (ø)
...apture/crumbs/LegacyWebViewBreadcrumbDataSource.kt	46.66% <100.00%> (ø)
.../embracesdk/capture/crumbs/WebViewUrlDataSource.kt	70.83% <70.83%> (ø)

... and 4 files with indirect coverage changes