Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete go implementation #276

Merged
merged 4 commits into from
Jun 22, 2018
Merged

Delete go implementation #276

merged 4 commits into from
Jun 22, 2018

Conversation

ry
Copy link
Member

@ry ry commented Jun 21, 2018

The old implementation will stay around at: https://github.com/ry/deno/tree/golang

I want to delete these files to reduce confusion

After this we will rename deno2 to src

#270 should be landed first

@ry ry requested a review from piscisaureus June 21, 2018 20:21
@tmc
Copy link

tmc commented Jun 22, 2018

Was looking forward to having a solid embeddable runtime for ts in go programs. Alas.

@ry
Copy link
Member Author

ry commented Jun 22, 2018

@tmc the double GC problem is too worrying to invest more into it.

@piscisaureus
Copy link
Member

LGTM

@piscisaureus
Copy link
Member

But lets rebase it first and see if travis still passes.

@ry ry mentioned this pull request Jun 22, 2018
@ry ry merged commit 86354a2 into master Jun 22, 2018
@ry ry deleted the reorg branch June 22, 2018 12:24
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants