[WIP] Travis to check deno2 #270
Conversation
ry
force-pushed
the
deno2_travis
branch
2 times, most recently
from
2a49587
to
614e891
Compare
ry
force-pushed
the
deno2_travis
branch
7 times, most recently
from
c912f62
to
db735da
Compare
.travis.yml
Outdated
| - export PATH=`pwd`/third_party/llvm-build/Release+Asserts/bin:$PATH | ||
| - (cd js; yarn) | ||
| - rm -f $BUILD_PATH/args.gn # Don't use cached values. | ||
| - gn gen $BUILD_PATH --args='is_debug=false cc_wrapper="ccache" use_custom_libcxx = false use_sysroot = false' |
There was a problem hiding this comment.
spaces around the equals sign (use_sysroot = false). That works?
deno2/.gn
Outdated
| @@ -8,7 +8,7 @@ buildconfig = "//build/config/BUILDCONFIG.gn" | |||
| # The secondary source root is a parallel directory tree where | |||
| # GN build files are placed when they can not be placed directly | |||
| # in the source tree, e.g. for third party source trees. | |||
| secondary_source = "//v8/" | |||
| #secondary_source = "//v8/" | |||
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
Removed completely. Symlinks are introduced in this commit that circumvent the need for this.
| "tmp": "0.0.33", | ||
| "uglify-js": "^2.8.29", | ||
| "espree": "^3.5.3", | ||
| "minimist": "^1.2.0" |
There was a problem hiding this comment.
Why are all these extra packages needed?
There was a problem hiding this comment.
These are packages that are automatically installed by protobufjs. I would have added a comment, but that isn't possible here. -_-
deno2/.gn
Outdated
| v8_imminent_deprecation_warnings = false | ||
| v8_monolithic = false | ||
| v8_monolithic = true | ||
| v8_static_library=false |
There was a problem hiding this comment.
Does this mean we're building a shared library? Or does v8_monolithic turn it into yet something else?
There was a problem hiding this comment.
Removed. Everything is statically linked in the end - this is inconsequential to our task
ry
force-pushed
the
deno2_travis
branch
4 times, most recently
from
cea6997
to
8f13534
Compare
|
Supports deno_rs now and added comments. |
Plan: