Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on Windows #275

Closed
wants to merge 1 commit into from
Closed

Fix building on Windows #275

wants to merge 1 commit into from

Conversation

seishun
Copy link
Contributor

@seishun seishun commented Jun 19, 2018

  • cmd doesn't support semicolons, use && instead.
  • Run python explicitly.
  • Use quote escaping that works in both bash and cmd.
  • Set DEPOT_TOOLS_WIN_TOOLCHAIN=0 by default (to avoid non-googlers
    being asked for credentials).
  • Pass shell=True to run .bat files.

See also: v8/node#60

- cmd doesn't support semicolons, use && instead.
- Run `python` explicitly.
- Use quote escaping that works in both bash and cmd.
- Set `DEPOT_TOOLS_WIN_TOOLCHAIN=0` by default (to avoid non-googlers
being asked for credentials).
- Pass `shell=True` to run .bat files.

See also: v8/node#60
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2018

CLA assistant check
All committers have signed the CLA.

@piscisaureus
Copy link
Member

@seishun Does ccache work for you at all? Where did you get it from?

@seishun
Copy link
Contributor Author

seishun commented Jun 20, 2018

Nope. As far as I can tell, cc_wrapper is ignored on Windows.

@ry
Copy link
Member

ry commented Jun 21, 2018

@seishun appreciate the effort but we need to get these tools building in linux first. I'm going to close this. We will be compatible with windows - just everything is in flux right now.

@ry ry closed this Jun 21, 2018
@piscisaureus piscisaureus reopened this Jun 22, 2018

gn gen out/Debug --args='cc_wrapper="ccache" is_debug=true '
gn gen out/Debug --args="cc_wrapper=\"ccache\" is_debug=true "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but unnecessarily complex. Just remove the quotes around ccache completely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work here:

~/deno/deno2$ gn gen out/Debug --args="cc_wrapper=ccache is_debug=true "
ERROR at the command-line "--args":1:12: Undefined identifier
cc_wrapper=ccache is_debug=true
           ^-----

Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, but see comments.

@@ -23,6 +23,9 @@ def main():
os.chdir(root_path)
buildName = "Debug" if args.debug else "Default"
buildDir = os.path.join(root_path, "out", buildName)
# Default to non-Googler configuration.
if 'DEPOT_TOOLS_WIN_TOOLCHAIN' not in os.environ:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to doing this, also print out a me.ssage. Otherwise people are going to scratch their head too much when running gn directly and it doesn't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the note I added in README.md is insufficient?

@piscisaureus
Copy link
Member

piscisaureus commented Jun 22, 2018

@ry I don't think it's unreasonable to land this. I've been meaning to write this down, but didn't.

@ry
Copy link
Member

ry commented Jun 22, 2018

I would rather remove build.py entirely since it's not used in CI and we don't use it. Maybe when the dust settles we can make a user friendly build script - but now it's just going to get out of sync - and we don't particularly want people who can't figure out depot_tools here.

@piscisaureus
Copy link
Member

Yeah, let's remove build.py

@ry
Copy link
Member

ry commented Jun 22, 2018

Closed in favor of #276. Thanks @seishun

@ry ry closed this Jun 22, 2018
@seishun
Copy link
Contributor Author

seishun commented Jun 22, 2018

#276 doesn't include the README.md changes though.

@seishun seishun deleted the deno2-win branch February 3, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants