Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename deno2 into src #277

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Rename deno2 into src #277

merged 1 commit into from
Jun 22, 2018

Conversation

TristanMarion
Copy link
Contributor

@TristanMarion TristanMarion commented Jun 22, 2018 •
edited
Loading

In #276 you said

After this we will rename deno2 to src

Here is your change 😅

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TristanMarion TristanMarion changed the title Move deno2 folder to src Rename deno2 into to src Jun 22, 2018
@TristanMarion TristanMarion changed the title Rename deno2 into to src Rename deno2 into src Jun 22, 2018
ry
ry approved these changes Jun 22, 2018
View reviewed changes
Copy link
Member

@ry ry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks Tristan!

Next up is to move .gn, BUILD.gn and associated symlinks to the root

@ry ry merged commit 3b59525 into denoland:master Jun 22, 2018
@TristanMarion TristanMarion deleted the deno2-to-src branch June 22, 2018 13:39
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Oct 7, 2019
@zekth @ry
Improve jsdoc (denoland#277)
1805c18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TristanMarion @CLAassistant @ry