fix(npm): cache bust npm specifiers more aggressively #18636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some leftover code from previous iterations, where keys could be single parts instead of arrays also. This didn't match the types.
dsherret
force-pushed
the
fix_cache_bust_npm_specifiers_more_aggressively
branch
from
0832cfb
to
d13d3f9
Compare
bartlomieju
approved these changes
Apr 12, 2023
Comment on lines
+40
to
+47
| ) -> FuturesOrdered< | ||
| impl Future< | ||
| Output = Result< | ||
| (&NpmPackageReq, Arc<deno_npm::registry::NpmPackageInfo>), | ||
| NpmRegistryPackageInfoLoadError, | ||
| >, | ||
| >, | ||
| > { |
There was a problem hiding this comment.
I'm surprised clippy doesn't complain about too complex type here.
Comment on lines
+104
to
+107
| if inner.npm_registry_api.mark_force_reload() { | ||
| log::debug!("Failed to resolve package. Retrying. Error: {err:#}"); | ||
| // re-initialize | ||
| inner.npm_registry_api.clear_memory_cache(); |
levex
pushed a commit
that referenced
this pull request
Apr 12, 2023
Part 1: #18622 Part 2: This PR Closes #16901 --------- Co-authored-by: Luca Casonato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1: #18622
Part 2: This PR
Closes #16901