Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache bust npm specifiers more aggressively #16901

Closed
oscarotero opened this issue Dec 2, 2022 · 4 comments · Fixed by #18636
Closed

Cache bust npm specifiers more aggressively #16901

oscarotero opened this issue Dec 2, 2022 · 4 comments · Fixed by #18636
Labels
node compat

Comments

@oscarotero
Copy link
Contributor

Everytime I want to update any NPM package to the latest version, I get the following error:

Could not find npm package 'lightningcss-wasm' matching 1.17.1. Try retrieving the latest npm package information by running with --reload

Is there any way to update it without need to add the --reload flag? It's very unconvenient for Lume users.
@dsherret
Copy link
Member

dsherret commented Dec 2, 2022

We've talked about cache busting when someone uses a new npm specifier. Would that work in this scenario?

@oscarotero
Copy link
Contributor Author

If I understand correctly, if I'm using npm:[email protected] and then change it to npm:[email protected], it's considered a new npm specifier, so it doesn't use the old cache, right? In that case, I guess it shoud work.

@dsherret
Copy link
Member

dsherret commented Dec 2, 2022

Yeah, in that scenario it would requery npm for the latest package information for everything (just package information and would not redownload package tarballs).

@dsherret dsherret changed the title Error updating npm packages Cache bust npm specifiers more aggressively Dec 2, 2022
@dsherret dsherret mentioned this issue Dec 2, 2022
Closed
25 tasks
@oscarotero oscarotero mentioned this issue Dec 21, 2022
Closed
@bartlomieju bartlomieju added this to the 1.31 milestone Jan 26, 2023
@kachick kachick mentioned this issue Jan 27, 2023
Closed
@bartlomieju bartlomieju mentioned this issue Feb 20, 2023
Merged
@bartlomieju bartlomieju removed this from the 1.31 milestone Feb 21, 2023
@oscarotero oscarotero mentioned this issue Mar 2, 2023
Closed
@dsherret dsherret mentioned this issue Apr 7, 2023
Merged
@dsherret
Copy link
Member

dsherret commented Apr 7, 2023

#18622 should help a lot with this, but it doesn't fully solve the problem.

dsherret added a commit that referenced this issue Apr 7, 2023
@dsherret
fix(npm): reload an npm package's dependency's information when versi…
5c7f76c 
…on not found (#18622)

This reloads an npm package's dependency's information when a
version/version req/tag is not found.

This PR applies only to dependencies of npm packages. It does NOT yet
cause npm specifiers to have their dependency information cache busted.
That requires a different solution, but this should help cache bust in
more scenarios.

Part of #16901, but doesn't close it yet
@dsherret dsherret mentioned this issue Apr 8, 2023
Merged
dsherret added a commit that referenced this issue Apr 12, 2023
@dsherret @lucacasonato
fix(npm): cache bust npm specifiers more aggressively (#18636)
0e3f62d 
Part 1: #18622 
Part 2: This PR

Closes #16901

---------

Co-authored-by: Luca Casonato <[email protected]>
levex pushed a commit that referenced this issue Apr 12, 2023
@dsherret @levex
fix(npm): reload an npm package's dependency's information when versi…
0117281 
…on not found (#18622)

This reloads an npm package's dependency's information when a
version/version req/tag is not found.

This PR applies only to dependencies of npm packages. It does NOT yet
cause npm specifiers to have their dependency information cache busted.
That requires a different solution, but this should help cache bust in
more scenarios.

Part of #16901, but doesn't close it yet
levex pushed a commit that referenced this issue Apr 12, 2023
@dsherret @lucacasonato @levex
fix(npm): cache bust npm specifiers more aggressively (#18636)
4fab252 
Part 1: #18622 
Part 2: This PR

Closes #16901

---------

Co-authored-by: Luca Casonato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
node compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(npm): cache bust npm specifiers more aggressively dsherret/deno
3 participants
@oscarotero @dsherret @bartlomieju