Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/kv): keys must be arrays #18655

Merged
merged 2 commits into from
Apr 11, 2023
Merged

fix(ext/kv): keys must be arrays #18655

merged 2 commits into from
Apr 11, 2023

Conversation

lucacasonato
Copy link
Member

There was some leftover code from previous iterations, where keys could
be single parts instead of arrays also. This didn't match the types.

There was some leftover code from previous iterations, where keys could
be single parts instead of arrays also. This didn't match the types.
Copy link
Member

@losfair losfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato enabled auto-merge (squash) April 11, 2023 10:06
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@lucacasonato lucacasonato merged commit e0bf8e6 into main Apr 11, 2023
@lucacasonato lucacasonato deleted the kv_keys_must_be_arrays branch April 11, 2023 14:36
@ry
Copy link
Member

ry commented Apr 11, 2023

It's kinda annoying one can't simply do kv.get("counter")...

dsherret pushed a commit to dsherret/deno that referenced this pull request Apr 11, 2023
There was some leftover code from previous iterations, where keys could
be single parts instead of arrays also. This didn't match the types.
levex pushed a commit that referenced this pull request Apr 12, 2023
There was some leftover code from previous iterations, where keys could
be single parts instead of arrays also. This didn't match the types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants