Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): cache bust npm specifiers more aggressively #18636

Merged
merged 13 commits into from
Apr 12, 2023
Merged

fix(npm): cache bust npm specifiers more aggressively #18636

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fecac0d
fix(npm): cache bust npm specifiers more aggressively
dsherret Apr 8, 2023
e7d2da8
Remove leftover code
dsherret Apr 8, 2023
e7f306e
Merge branch 'main' into fix_cache_bust_npm_specifiers_more_aggressively
dsherret Apr 8, 2023
cc86b16
chore: .gitignore spring cleaning (#18644)
dsherret Apr 9, 2023
5d25a93
fix(ext/kv): keys must be arrays (#18655)
lucacasonato Apr 11, 2023
847324c
Fix.
dsherret Apr 11, 2023
ff25c23
fix(npm): do not "npm install" when npm specifier happens to match pa…
dsherret Apr 11, 2023
d3969ca
Future proof test
dsherret Apr 11, 2023
69da42b
Fix test name.
dsherret Apr 11, 2023
49d7b2f
Shorter name (sorry for all the updates)
dsherret Apr 11, 2023
aef9f2b
Finish, but waiting on other PR to be reviewed first.
dsherret Apr 11, 2023
7db4b32
Merge branch 'main' into fix_cache_bust_npm_specifiers_more_aggressively
dsherret Apr 11, 2023
d13d3f9
Maybe fix
dsherret Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Future proof test
  • Loading branch information
@dsherret
dsherret committed Apr 11, 2023
commit d3969caec25d2c4e7be6930bf1451bb191fbb06f
7 changes: 5 additions & 2 deletions cli/tests/integration/cache_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,12 @@ fn cache_matching_package_json_dep_should_not_reload() {
let temp_dir = context.temp_dir();
temp_dir.write(
"package.json",
r#"{ "dependencies": { "@types/node": "*", "@denotest/esm-basic": "*" } }"#,
r#"{ "dependencies": { "@types/node": "18.8.2", "@denotest/esm-basic": "*" } }"#,
);
let output = context.new_command().args("cache npm:@types/node").run();
let output = context
.new_command()
.args("cache npm:@types/[email protected]")
.run();
output.assert_matches_text(concat!(
"Download https://localhost:4545/npm/registry/@types/node\n",
"Download https://localhost:4545/npm/registry/@types/node/node-18.8.2.tgz\n",
Expand Down