This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Set install path for libmxnet.so dynamic lib on Mac OS #13629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apeforest @anirudh2290 Please take a look |
|
@mxnet-label-bot update [pr-awaiting-review] |
anirudh2290
approved these changes
Dec 13, 2018
|
@mxnet-label-bot update [pr-awaiting-merge] |
marcoabreu
added
pr-awaiting-merge
zhaoyao73
added a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
* upstream/master: (38 commits) Feature/mkldnn static (apache#13628) Fix the bug of BidirectionalCell (apache#13575) Set install path for libmxnet.so dynamic lib on Mac OS (apache#13629) add batch norm test (apache#13625) Scripts for building dependency libraries of MXNet (apache#13282) fix quantize pass error when the quantization supported Op are excluded in the model (apache#13596) Optimize C++ API (apache#13496) Fix warning in waitall doc (apache#13618) [MXNET-1225] Always use config.mk in make install instructions (apache#13364) [MXNET-1224]: improve scala maven jni build and packing. (apache#13493) [MXNET-1155] Add scala packageTest utility (apache#13046) fix the Float not showing correctly problem (apache#13617) apache#13385 [Clojure] - Turn examples into integration tests (apache#13554) Add Intel MKL blas to Jenkins (apache#13607) Revert "[MXNET-1198] MXNet Java API (apache#13162)" Reducing the length of setup tutorial (apache#13306) [MXNET-1182] Predictor example (apache#13237) [MXNET-1187] Added Java SSD Inference Tutorial for website (apache#13201) add defaults and clean up the tests (apache#13295) [MXNET-1181] Added command line alternative to IntelliJ in install instructions (apache#13267) ...
|
This crash the Scala build [update with my tests...] Scala issue |
|
step to reproduce: |
|
@lanking520 let's discuss offline. |
5 tasks
piyushghai
pushed a commit
to piyushghai/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
lanking520
pushed a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Apr 26, 2019
lanking520
pushed a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Apr 30, 2019
zachgk
pushed a commit
to zachgk/incubator-mxnet
that referenced
this pull request
May 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a linker flag in Makefile to set the install path for libmxnet.so dynamic library on Mac OS. With this change, any clients linked against libmxnet.so will automatically record the path as the way dyld should locate it on Mac OS. One use case for this is to run Horovod with MXNet on Mac OS without changing the install path for libmxnet manually after installing Horovod.