Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add build fix for Scala/Java build #13655

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

lanking520
Copy link
Member

Description

Fixed with PR #13629
@gigasquid @nswamy @yzhliu @apeforest @yuxihu @zachgk @piyushghai

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the quick change @lanking520
LGTM!

Copy link
Member

@yuxihu yuxihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lanking520 Thanks for making the change. LGTM.

@gigasquid gigasquid self-requested a review December 15, 2018 18:35
Copy link
Member

@gigasquid gigasquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built on my OSX machine and ran Clojure tests.

Thanks for fixing this 💯

@gigasquid gigasquid mentioned this pull request Dec 15, 2018
4 tasks
@lanking520 lanking520 merged commit aa240cb into apache:master Dec 16, 2018
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Dec 18, 2018
@lanking520 lanking520 deleted the scala-build-fix branch March 11, 2019 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants