This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Feature/mkldnn static #13628
Merged
Feature/mkldnn static #13628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a3eca5f.
Vikas-kum
approved these changes
Dec 12, 2018
ZhennanQin
reviewed
Dec 13, 2018
| ifneq ($(UNAME_S), Windows) | ||
| LIB_DEP += $(MKLDNNROOT)/lib/libmkldnn.a | ||
| else | ||
| LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,'$${ORIGIN}' |
There was a problem hiding this comment.
VS compiler doesn't know those flags. Do we support VS build with Makefile?
There was a problem hiding this comment.
Nope, windows uses cmake
There was a problem hiding this comment.
@marcoabreu Thanks for explanation. This is as I expected. So we don't need to consider Windows build in Makefile.
There was a problem hiding this comment.
Why don't remove LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,'$${ORIGIN}'? It doesn't work on Windows.
There was a problem hiding this comment.
The line was there before. I am not trying to change builds on windows.
There was a problem hiding this comment.
This line is used for Linux MKLDNN dynamic build. Then why not remove it? As @marcoabreu said, Windows build doesn't use Makefile.
anirudh2290
approved these changes
Dec 13, 2018
7 tasks
zhaoyao73
added a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
* upstream/master: (38 commits) Feature/mkldnn static (apache#13628) Fix the bug of BidirectionalCell (apache#13575) Set install path for libmxnet.so dynamic lib on Mac OS (apache#13629) add batch norm test (apache#13625) Scripts for building dependency libraries of MXNet (apache#13282) fix quantize pass error when the quantization supported Op are excluded in the model (apache#13596) Optimize C++ API (apache#13496) Fix warning in waitall doc (apache#13618) [MXNET-1225] Always use config.mk in make install instructions (apache#13364) [MXNET-1224]: improve scala maven jni build and packing. (apache#13493) [MXNET-1155] Add scala packageTest utility (apache#13046) fix the Float not showing correctly problem (apache#13617) apache#13385 [Clojure] - Turn examples into integration tests (apache#13554) Add Intel MKL blas to Jenkins (apache#13607) Revert "[MXNET-1198] MXNet Java API (apache#13162)" Reducing the length of setup tutorial (apache#13306) [MXNET-1182] Predictor example (apache#13237) [MXNET-1187] Added Java SSD Inference Tutorial for website (apache#13201) add defaults and clean up the tests (apache#13295) [MXNET-1181] Added command line alternative to IntelliJ in install instructions (apache#13267) ...
azai91
added a commit
to azai91/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
This reverts commit 5bcf2bd.
anirudh2290
pushed a commit
that referenced
this pull request
Dec 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently MKLDNN is dynamically linked to mxnet. This can cause some issues if another version of mkldnn is present on the host machine and mxnet links to the host version. This change statically builds mkldnn into mxnet to handle version issues on linux/mac but keeps it dynamically linked on windows.
removed test_mkldnn_install.py from test as well since it tests if mkldnn is dynamically linked on linux (which it is no longer is)
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments