Optimize C++ API #13496
Optimize C++ API #13496
Conversation
Pass parameter with reference instead of value. Add const as well as it is not changed.
|
@mxnet-label-bot add [C++, pr-awaiting-review] @leleamol for review |
marcoabreu
added
C++
Fix BinaryShapeFunction typedef Add a right brace for SmoothL1Shape_
|
any idea why centos-cpu still not done? |
|
@marcoabreu May I ask why the centos-cpu still not done? |
|
Seems like it hasn't been kicked off. Please rebase to start another build |
|
do I need to do anything? |
|
@marcoabreu are we missing statuses from github? Check centos-cpu |
|
@zhaoyao73 I have kicked off a build on your behalf. Sorry for the inconveniences. |
|
@marcoabreu just a dummy question, can I start a CI build? |
|
Yeah, just make a new commit and it will automatically start a build |
|
@mxnet-label-bot [pr-awaiting-merge] |
|
weird, look at this PR it is still pr-awaiting-review, although I see @larrroy put the pr-awaiting-merge? |
|
You received two binding approvals, no requested changes and there are no outstanding discussions, thus the PR is ready to be merged. |
* upstream/master: (38 commits) Feature/mkldnn static (apache#13628) Fix the bug of BidirectionalCell (apache#13575) Set install path for libmxnet.so dynamic lib on Mac OS (apache#13629) add batch norm test (apache#13625) Scripts for building dependency libraries of MXNet (apache#13282) fix quantize pass error when the quantization supported Op are excluded in the model (apache#13596) Optimize C++ API (apache#13496) Fix warning in waitall doc (apache#13618) [MXNET-1225] Always use config.mk in make install instructions (apache#13364) [MXNET-1224]: improve scala maven jni build and packing. (apache#13493) [MXNET-1155] Add scala packageTest utility (apache#13046) fix the Float not showing correctly problem (apache#13617) apache#13385 [Clojure] - Turn examples into integration tests (apache#13554) Add Intel MKL blas to Jenkins (apache#13607) Revert "[MXNET-1198] MXNet Java API (apache#13162)" Reducing the length of setup tutorial (apache#13306) [MXNET-1182] Predictor example (apache#13237) [MXNET-1187] Added Java SSD Inference Tutorial for website (apache#13201) add defaults and clean up the tests (apache#13295) [MXNET-1181] Added command line alternative to IntelliJ in install instructions (apache#13267) ...
Pass parameter with reference instead of value.
Add const as well as it is not changed.
Description
Optimize some functions to pass reference instead of value. This could avoid unnecessary construction/destruction and copy.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Didn't find the API doc in mxnet.io/doxygen
Changes
Comments
I am not sure I could run a sanity test with it or how to run a unit test/sanity test against the change. But pass value -> pass reference, should be transparent to C++, although not like C's pass value->pass pointer.