[WIP] commander: remove multicopter nav test #23338
Draft
+2
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs careful review.
I'd like to remove the multicopter navigation test in commander because I think it's no longer needed and has the potential to do more harm than good latching on a false positive.
It's not that common anymore, but I've seen examples where we would have recovered (or were in the process of recovering), but this "nav test" triggers (latched) and you're done (velocity and position locked invalid).
The counter example I'm looking for is if this ever triggers and actually prevented a fallway that the EKF2 yaw estimator wouldn't have caught.