-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MC autotune: change signal input to sine sweep #21857
Draft
bresch
wants to merge
12
commits into
main
Choose a base branch
from
pr-autotune-sine-sweep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+287
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bresch
force-pushed
the
pr-autotune-sine-sweep
branch
from
July 18, 2023 12:26
931fb38
to
0c1419c
Compare
bresch
force-pushed
the
pr-autotune-sine-sweep
branch
from
July 28, 2023 14:30
0c1419c
to
94f6c6b
Compare
bresch
force-pushed
the
pr-autotune-sine-sweep
branch
from
December 21, 2023 08:59
94f6c6b
to
177a91d
Compare
bresch
force-pushed
the
pr-autotune-sine-sweep
branch
from
January 4, 2024 15:02
177a91d
to
addaaf0
Compare
Merged
Sine sweeps are covering a much wide range of frequencies than doublets, giving better identification results
Equations from: R. Allred, Digital Filters for Everyone
No difference in practice
We usually don't want the high frequency response in our reduced order model
Rearrange to look like a KF
bresch
force-pushed
the
pr-autotune-sine-sweep
branch
from
January 24, 2024 09:04
addaaf0
to
abdc990
Compare
Dev call: Change to have multi-step by default. Then merge refactor and test both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
In some cases, the gains obtained by auto-tuning weren't good enough because the system identification wasn't able to capture the dynamics properly.
Solution
One possible cause of a poor model identification is when the dominant dynamics are not correctly excited.
This PR changes the current doublet input signal to sine sweeps (as suggested by Ryan Beall). As they cover a wider range of frequencies, they give a higher chance to correctly capture the system dynamics.
The current implementation is also more generic and other signal types can be added.
Changelog Entry
For release notes:
Test coverage
SITL tests for now