Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavlink: add initial mavlink OPEN_DRONE_ID_SYSTEM stream #20563

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

dagar
Copy link
Member

@dagar dagar commented Nov 7, 2022

msg.category_eu = MAV_ODID_CATEGORY_EU_UNDECLARED;
msg.class_eu = MAV_ODID_CLASS_EU_UNDECLARED;
msg.operator_altitude_geo = home_position.alt;
msg.timestamp = home_position.timestamp; // TODO: 32 bit Unix Timestamp in seconds since 00:00:00 01/01/2019.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this timestamp needs improvement. I did try home_position.timestamp/1000000 - 1546300800, but that didn't work. For the rest, both system and location messages are received by the RemoteID transmitter and broadcast.

ToDo is: a) fix the timestamp b) stream the live operator position. @ryanjAA do you have ideas/preference how to stream the live position?

Screenshot_2022-11-12-15-37-51-63_18ad2714093a0264057c4c4529de4be8

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BluemarkInnovations we spoke about this on the dev call. It makes most sense to plug a gps into your computer (or use one internal if on a tablet) and stream from QGC back up. It may or may not take a QGC change but it can already read NMEA and live position if you have gps.

That seems like the best path and then as @dagar said, if we have rtk and related in use we can start to benefit system wide from that data.

Let me know your thoughts.

Copy link

@BluemarkInnovations BluemarkInnovations Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

st sense to plug a gps into your computer (or use one internal if on a tablet) and stream from QGC back up. It may or may not take a QGC change but it can already read NMEA and live position if you have gps.

@ryanjAA I do know that there are customers using ArduPilot and a Herelink running QGC. In that product there is RemoteID functionality already. Not sure if that is part of QGC or something Hex implemented. So it seems to me a good approach. And if the RemoteID functionality is already be part of QGC, only a few steps are needed to get a dynamic location in the RemoteID signal.

@dagar dagar force-pushed the pr-mavlink_OPEN_DRONE_ID_SYSTEM branch 2 times, most recently from 7658aad to de943d7 Compare December 13, 2022 19:22
@dagar dagar force-pushed the pr-mavlink_OPEN_DRONE_ID_SYSTEM branch from de943d7 to a5efaca Compare December 13, 2022 19:24
@dagar dagar merged commit 4d318eb into main Dec 14, 2022
@dagar dagar deleted the pr-mavlink_OPEN_DRONE_ID_SYSTEM branch December 14, 2022 00:39
@BluemarkInnovations
Copy link

I did a final check, the time information is correct now.

Screenshot_2022-12-15-17-25-23-17_18ad2714093a0264057c4c4529de4be8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants