feat(api): change liquid_probe to respect min well height #15488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to liquid_probe_in_place that will not go to the very bottom of the well, but stop slightly above it(as specified by the well's minimum height) fix EXEC-576
sfoster1
previously requested changes
Jun 24, 2024
| @@ -413,6 +413,37 @@ def get_should_center_pipette_on_target_well(self, labware_id: str) -> bool: | |||
| or len(self.get_definition(labware_id).wells) >= 96 | |||
| ) | |||
|
|
|||
| def get_well_min_height(self, labware_id: str, well_name: str) -> float: | |||
| """Get's the minimum distance that a liquid probe must stop away from the bottom of a well. | |||
There was a problem hiding this comment.
Suggested change
| """Get's the minimum distance that a liquid probe must stop away from the bottom of a well. | |
| """Gets the minimum distance that a liquid probe must stop away from the bottom of a well. |
| return float(entry["value"]) | ||
| if ( | ||
| entry["applicableWells"] == [] | ||
| ): # A "custom" default value will have "applicableWells" set to [] |
There was a problem hiding this comment.
will it? or will it have applicableWells set to a list of all the wells?
ryanthecoder
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to liquid_probe_in_place that will not go to the very bottom of the well, but stop
slightly above it(as specified by the well's minimum height)
fix EXEC-576
Overview
Test Plan
Changelog
Review requests
Risk assessment