Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app): add new icons for ODD hi-fi #12231

Merged
merged 1 commit into from
Mar 6, 2023
Merged

chore(app): add new icons for ODD hi-fi #12231

merged 1 commit into from
Mar 6, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 3, 2023

Overview

Add new icons for ODD hi-fi
close RAUT-334

except move-xy
Screenshot 2023-03-03 at 5 05 56 PM

Test Plan

Changelog

Review requests

Risk assessment

low

@koji koji marked this pull request as ready for review March 3, 2023 22:14
@koji koji requested a review from a team as a code owner March 3, 2023 22:14
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #12231 (f045781) into edge (ce1ea36) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #12231   +/-   ##
=======================================
  Coverage   74.01%   74.01%           
=======================================
  Files        2193     2193           
  Lines       60360    60360           
  Branches     6223     6223           
=======================================
  Hits        44676    44676           
  Misses      14254    14254           
  Partials     1430     1430           
Flag Coverage Δ
app 72.60% <ø> (ø)
components 65.17% <ø> (ø)
labware-library 49.74% <ø> (ø)
protocol-designer 46.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/src/icons/icon-data.ts 100.00% <ø> (ø)

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ 🎊

@koji koji merged commit bf4d447 into edge Mar 6, 2023
y3rsh added a commit that referenced this pull request Mar 6, 2023
* edge:
  refactor(protocol-engine): Shorten error docstrings (#12230)
  chore(app): update electron-builder version from v24 alpha to v24 (#12233)
  chore(app): add new icons for ODD hi-fi (#12231)
  docs: more release docs (#12226)
  fix(app, odd): check isOnDevice true instead of if it is null (#12228)
  docs: remove references to make bump in releasing (#12222)
  refactor(app): scroll to current split from jump to tick, qol tweaks to run preview (#12218)
  fix(app): rewire cli and jupyter snippets to offsets modals  (#12180)
  feat(app): handle non-deterministic protocols (#12173)
TamarZanzouri pushed a commit that referenced this pull request Mar 8, 2023
TamarZanzouri pushed a commit that referenced this pull request Mar 9, 2023
@koji koji deleted the chore_add-icons-for-odd branch June 17, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants