docs: remove references to make bump in releasing #12222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for how we use tags instead of make bump.
b-cooper
reviewed
Mar 3, 2023
| ```shell | ||
| make bump project=${project} version=${version} | ||
| ${projectPrefix}${projectVersion} |
There was a problem hiding this comment.
Suggested change
| ${projectPrefix}${projectVersion} | |
| git tag -a ${projectPrefix}${projectVersion} -m 'chore(release): ${projectPrefix}${version}' |
There was a problem hiding this comment.
No, this defines the name of the tag, not the command itself. Then there's examples of tags. The commands to use are inline in the instructions.
There was a problem hiding this comment.
ok, then it may be worth calling out that the tag message should include the project prefix too right (e.g. chore(release): [email protected])?
There was a problem hiding this comment.
we haven't previously been doing that (and also ot isn't a project prefix - flex uses ot3, robot stack uses v)
Codecov Report
@@ Coverage Diff @@
## edge #12222 +/- ##
==========================================
- Coverage 74.01% 73.70% -0.31%
==========================================
Files 2193 1476 -717
Lines 60358 48416 -11942
Branches 6223 2978 -3245
==========================================
- Hits 44674 35687 -8987
+ Misses 14254 12276 -1978
+ Partials 1430 453 -977
Flags with carried forward coverage won't be shown. Click here to find out more. |
y3rsh
added a commit
that referenced
this pull request
Mar 6, 2023
* edge: refactor(protocol-engine): Shorten error docstrings (#12230) chore(app): update electron-builder version from v24 alpha to v24 (#12233) chore(app): add new icons for ODD hi-fi (#12231) docs: more release docs (#12226) fix(app, odd): check isOnDevice true instead of if it is null (#12228) docs: remove references to make bump in releasing (#12222) refactor(app): scroll to current split from jump to tick, qol tweaks to run preview (#12218) fix(app): rewire cli and jupyter snippets to offsets modals (#12180) feat(app): handle non-deterministic protocols (#12173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed to a direct tag-based version process and don't use
make bumpanymore (we don't even havelernainstalled) so let's remove the actualmake bumptarget that doesn't work anymore and update RELEASING.md to contain the new information.