fix(app, odd): check that isOnDevice true instead of null #12228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #12228 +/- ##
=======================================
Coverage 74.01% 74.02%
=======================================
Files 2193 2193
Lines 60360 60360
Branches 6223 6223
=======================================
+ Hits 44676 44679 +3
+ Misses 14254 14252 -2
+ Partials 1430 1429 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
y3rsh
added a commit
that referenced
this pull request
Mar 6, 2023
* edge: refactor(protocol-engine): Shorten error docstrings (#12230) chore(app): update electron-builder version from v24 alpha to v24 (#12233) chore(app): add new icons for ODD hi-fi (#12231) docs: more release docs (#12226) fix(app, odd): check isOnDevice true instead of if it is null (#12228) docs: remove references to make bump in releasing (#12222) refactor(app): scroll to current split from jump to tick, qol tweaks to run preview (#12218) fix(app): rewire cli and jupyter snippets to offsets modals (#12180) feat(app): handle non-deterministic protocols (#12173)
TamarZanzouri
pushed a commit
that referenced
this pull request
Mar 8, 2023
TamarZanzouri
pushed a commit
that referenced
this pull request
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fixes bug where code thought the pipette flow was being accessed from the ODD instead of the desktop app
Test Plan
BeforeBeginningand subsequent modals in the flow should render normally with thePortalChangelog
isOnDeviceboolean logic inPipetteWizardFlowsReview requests
Test PlanRisk assessment
low