-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): rewire cli and jupyter snippets to offsets modals #12180
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #12180 +/- ##
==========================================
- Coverage 74.03% 73.95% -0.09%
==========================================
Files 2172 2156 -16
Lines 59836 59327 -509
Branches 6145 6453 +308
==========================================
- Hits 44302 43873 -429
+ Misses 14151 13983 -168
- Partials 1383 1471 +88
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and @ecormany agrees
The generated snippets look correct. I tested by doing a run with this protocol: metadata = {
"apiLevel": "2.14"
}
def run(protocol):
temperature_module = protocol.load_module("temperature module gen2", 4)
tip_rack = protocol.load_labware("opentrons_96_tiprack_300ul", 6)
pcr_strips = temperature_module.load_labware("opentrons_96_aluminumblock_generic_pcr_strip_200ul")
pipette = protocol.load_instrument("p300_single_gen2", mount="left", tip_racks=[tip_rack])
pipette.pick_up_tip()
pipette.aspirate(25, pcr_strips["A2"].bottom(z=1))
pipette.dispense(25, pcr_strips["H11"].bottom(z=0.8))
pipette.return_tip() The app generated this snippet: import opentrons.execute
protocol = opentrons.execute.get_protocol_api("2.13")
module_1 = protocol.load_module("temperatureModuleV2", location="4")
labware_1 = protocol.load_labware("opentrons_96_tiprack_300ul", location="6")
labware_1.set_offset(x=0.00, y=1.20, z=2.00)
labware_2 = module_1.load_labware("opentrons_96_aluminumblock_generic_pcr_strip_200ul")
labware_2.set_offset(x=1.10, y=0.50, z=-10.50) |
* edge: refactor(protocol-engine): Shorten error docstrings (#12230) chore(app): update electron-builder version from v24 alpha to v24 (#12233) chore(app): add new icons for ODD hi-fi (#12231) docs: more release docs (#12226) fix(app, odd): check isOnDevice true instead of if it is null (#12228) docs: remove references to make bump in releasing (#12222) refactor(app): scroll to current split from jump to tick, qol tweaks to run preview (#12218) fix(app): rewire cli and jupyter snippets to offsets modals (#12180) feat(app): handle non-deterministic protocols (#12173)
Overview
Rewire and fix the CLI and Jupyter labware offset snippets to their three
new locations in the app.
Closes RLAB-300, and RLAB-196.
Review requests
Risk assessment
low, this is only available behind an advanced setting