feat(app): implement useCalibrationTaskList hook #11894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lated types to be reusable
useGenerateTaskList is a hook that aggregates deck calibrations and tip length and offset calibrations for attached pipettes then builds the taskList object that is passed to the TaskList component as props closes RAUT-291
jgbowser
changed the title
Codecov Report
@@ Coverage Diff @@
## edge #11894 +/- ##
==========================================
+ Coverage 74.24% 74.26% +0.02%
==========================================
Files 2167 2168 +1
Lines 60016 60093 +77
Branches 6307 6322 +15
==========================================
+ Hits 44556 44631 +75
Misses 13972 13972
- Partials 1488 1490 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jgbowser
force-pushed
the
raut-291-gen-calibration-task-list
branch
from
be7458f
to
e684a6e
Compare
|
@b-cooper @ewagoner Quick demonstration of it in action. Seems to be working, though I had to do some pretty wonky stuff with Screen.Recording.2022-12-15.at.11.41.21.AM.mov |
jgbowser
requested review from
TamarZanzouri and
a team
and removed request for
a team and
TamarZanzouri
jgbowser
force-pushed
the
raut-291-gen-calibration-task-list
branch
from
4bad6e1
to
8668fda
Compare
jgbowser
force-pushed
the
raut-291-gen-calibration-task-list
branch
from
8668fda
to
551408e
Compare
jgbowser
changed the title
b-cooper
approved these changes
Jan 5, 2023
y3rsh
added a commit
that referenced
this pull request
Jan 6, 2023
* origin/edge: (34 commits) refactor(app): update desktop robot settings calibration section for OT-3 (#11942) feat(hardware): add CAN message to update motor position from encoders (#11868) ci(monorepo): upgrade windows versions on github workflows (#11940) feat(app): implement useCalibrationTaskList hook (#11894) feat(app, app-shell, app-shell-odd): create node layer for ODD (#11944) refactor(app): Remove recalibrate option from POC and TLC overflow menus [RAUT-93] (#11915) fix(api): home z should home gripper z too (#11950) refactor(shared-data): gripper use force polynomial function (#11946) refactor(api): move `ModuleGeometry` to legacy protocol core module (#11939) refactor(api): deprecate `ModuleContext.geometry` (#11938) chore(usb-bridge): add usb-bridge tests to test-py, add restart to push-ot3 (#11937) Revert "feat(app-shell-odd): create node layer for ODD (#11852)" (#11941) feat(app-shell-odd): create node layer for ODD (#11852) feature(hardware): add a warning style to can_mon and an "estop_released" error id (#11924) fix(hardware): Remove while loop and rely on number_of_messages when parsing motor position response. (#11929) fix(hardware): save can_comm / can_mon logs to read-write location (#11933) feat(api): Support 96 channel in the hardware controller (#11866) refactor(app): revert run a protocol from devices pages (#11909) refactor(app): remove warnings (#11922) refactor(app): remove invalid type warnings for strings from atoms (#11918) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a
useCalibrationTaskListhook that can be used alongside the TaskList component in the Calibration Dashboard to generate a task list of calibrations that are passed in to the TaskList component.closes RAUT-291
Changelog
robot_calibration.jsonReview requests
Still getting familiar with a lot of these hooks and the calibrations they relate to, please ensure that the logic here is sound both when locating desired calibration data, and when building out the task list object
Risk assessment
low, the hook isn't being used anywhere yet