feat(app-shell-odd): create node layer for ODD #11852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #11852 +/- ##
==========================================
+ Coverage 74.18% 74.22% +0.03%
==========================================
Files 2164 1431 -733
Lines 59749 47364 -12385
Branches 6263 3013 -3250
==========================================
- Hits 44323 35154 -9169
+ Misses 13952 11743 -2209
+ Partials 1474 467 -1007
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shlokamin
force-pushed
the
app-shell_create-node-layer-for-ODD
branch
from
d5e49d1
to
0c1e399
Compare
shlokamin
commented
Dec 23, 2022
| @@ -13,7 +13,7 @@ interface File { | |||
| export interface UpdateInfo { | |||
| version: string | |||
| files: File[] | |||
| releaseDate: string | |||
| releaseDate?: string | |||
There was a problem hiding this comment.
releaseDate isn't provided by the OT-3 build manifest, but we also dont use releaseDate anywhere in the app
shlokamin
requested review from
b-cooper,
sfoster1 and
brenthagen
and removed request for
a team
shlokamin
changed the title
This reverts commit 7cbab2c.
shlokamin
added a commit
that referenced
this pull request
Jan 3, 2023
y3rsh
added a commit
that referenced
this pull request
Jan 6, 2023
* origin/edge: (34 commits) refactor(app): update desktop robot settings calibration section for OT-3 (#11942) feat(hardware): add CAN message to update motor position from encoders (#11868) ci(monorepo): upgrade windows versions on github workflows (#11940) feat(app): implement useCalibrationTaskList hook (#11894) feat(app, app-shell, app-shell-odd): create node layer for ODD (#11944) refactor(app): Remove recalibrate option from POC and TLC overflow menus [RAUT-93] (#11915) fix(api): home z should home gripper z too (#11950) refactor(shared-data): gripper use force polynomial function (#11946) refactor(api): move `ModuleGeometry` to legacy protocol core module (#11939) refactor(api): deprecate `ModuleContext.geometry` (#11938) chore(usb-bridge): add usb-bridge tests to test-py, add restart to push-ot3 (#11937) Revert "feat(app-shell-odd): create node layer for ODD (#11852)" (#11941) feat(app-shell-odd): create node layer for ODD (#11852) feature(hardware): add a warning style to can_mon and an "estop_released" error id (#11924) fix(hardware): Remove while loop and rely on number_of_messages when parsing motor position response. (#11929) fix(hardware): save can_comm / can_mon logs to read-write location (#11933) feat(api): Support 96 channel in the hardware controller (#11866) refactor(app): revert run a protocol from devices pages (#11909) refactor(app): remove warnings (#11922) refactor(app): remove invalid type warnings for strings from atoms (#11918) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the node layer (
app-shell-odd) to the app-shell.The main thing the new
app-shell-odddoes differently than theapp-shellis the way it facilitates software updates. We no longer rely on electron-updater to facilitate the process. The app will periodically tell the node layer to check if an update is available by pinging the OT-3 release manifest rather than having electron-updater do this for us. The reason for this is that we don't currently (and have no plans to) publish a standalone linux arm64 version of the app. Since electron-updater looks for updates for the OS that the app is running on, it has no way of knowing if an update is available.See this proposal for more info if you're curious
Closes RCORE-431, RCORE-432
Changelog
Review requests
make -C app-shell-odd push-ot3 host=ROBOT_IP)journalctl -f -u opentrons-update-server)Download latest OT-3 system version(it should take about a minute)Risk assessment
Low, this is not being used in production yet