Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(monorepo): upgrade windows versions on github workflows #11940

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

shlokamin
Copy link
Member

Overview

I downgraded the windows versions for CI workflows while debugging the app shell odd PR but forgot to put them back after I discovered that the CI workflows weren't the issue

Changelog

  • Update gh action windows versions

Review requests

Check that CI passes

Risk assessment

Low

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #11940 (5e96445) into edge (4de19cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #11940   +/-   ##
=======================================
  Coverage   74.23%   74.23%           
=======================================
  Files        2167     2167           
  Lines       60036    60036           
  Branches     6312     6312           
=======================================
  Hits        44569    44569           
  Misses      13979    13979           
  Partials     1488     1488           
Flag Coverage Δ
app 73.16% <ø> (ø)
protocol-designer 45.89% <ø> (ø)
shared-data 85.47% <ø> (ø)
step-generation 88.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@shlokamin shlokamin changed the base branch from edge to app-shell_create-node-layer-for-ODD January 4, 2023 19:11
Base automatically changed from app-shell_create-node-layer-for-ODD to edge January 5, 2023 20:03
@shlokamin shlokamin marked this pull request as ready for review January 5, 2023 20:06
@shlokamin shlokamin requested review from a team as code owners January 5, 2023 20:06
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@shlokamin shlokamin merged commit 7359e74 into edge Jan 5, 2023
y3rsh added a commit that referenced this pull request Jan 6, 2023
* origin/edge: (34 commits)
  refactor(app): update desktop robot settings calibration section for OT-3 (#11942)
  feat(hardware): add CAN message to update motor position from encoders (#11868)
  ci(monorepo): upgrade windows versions on github workflows (#11940)
  feat(app): implement useCalibrationTaskList hook (#11894)
  feat(app, app-shell, app-shell-odd): create node layer for ODD (#11944)
  refactor(app): Remove recalibrate option from POC and TLC overflow menus [RAUT-93] (#11915)
  fix(api): home z should home gripper z too (#11950)
  refactor(shared-data): gripper use force polynomial function  (#11946)
  refactor(api): move `ModuleGeometry` to legacy protocol core module (#11939)
  refactor(api): deprecate `ModuleContext.geometry` (#11938)
  chore(usb-bridge): add usb-bridge tests to test-py, add restart to push-ot3 (#11937)
  Revert "feat(app-shell-odd): create node layer for ODD (#11852)" (#11941)
  feat(app-shell-odd): create node layer for ODD (#11852)
  feature(hardware): add a warning style to can_mon and an "estop_released" error id (#11924)
  fix(hardware): Remove while loop and rely on  number_of_messages when parsing motor position response.  (#11929)
  fix(hardware): save can_comm / can_mon logs to read-write location (#11933)
  feat(api): Support 96 channel in the hardware controller (#11866)
  refactor(app): revert run a protocol from devices pages (#11909)
  refactor(app): remove warnings (#11922)
  refactor(app): remove invalid type warnings for strings from atoms (#11918)
  ...
@shlokamin shlokamin deleted the upgrade-windows-CI-OS branch March 15, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants