add test coverage for tip length calibration active index

Opentrons · Dec 19, 2022 · 8668fda · 8668fda
1 parent 0b4fe4f
commit 8668fda
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/app/src/organisms/Devices/__tests__/utils.test.tsx b/app/src/organisms/Devices/__tests__/utils.test.tsx
@@ -40,7 +40,7 @@ describe('getIs96ChannelPipetteAttached hook', () => {
 
  it('returns false when there is no 96 channel pipette attached on the left mount', () => {
  const mockLeftMountAttachedPipette = {
- name: 'mock single channel',
+ name: 'p1000_96',
  } as FetchPipettesResponsePipette
 
  const result = getIs96ChannelPipetteAttached(mockLeftMountAttachedPipette)

diff --git a/app/src/organisms/Devices/hooks/__tests__/useGenerateTaskList.test.tsx b/app/src/organisms/Devices/hooks/__tests__/useGenerateTaskList.test.tsx
@@ -116,7 +116,7 @@ describe('useGenerateTaskList hook', () => {
  expect(result.current.taskList[2].description).toEqual('Empty')
  })
 
- it('returns the the correct active index for a task that needs to be completed without subtasks', () => {
+ it('returns the the correct active when Deck Calibration is needed', () => {
  when(mockUseAttachedPipettes)
  .calledWith()
  .mockReturnValue(mockAttachedPipettesResponse)
@@ -136,7 +136,7 @@ describe('useGenerateTaskList hook', () => {
  expect(result.current.activeIndex).toEqual([0, 0])
  })
 
- it('returns the the correct active index for a task with a subtask that needs to be completed', () => {
+ it('returns the the correct active index when a pipette is missing Offset Calibrations', () => {
  when(mockUseAttachedPipettes)
  .calledWith()
  .mockReturnValue(mockAttachedPipettesResponse)
@@ -156,6 +156,26 @@ describe('useGenerateTaskList hook', () => {
  expect(result.current.activeIndex).toEqual([2, 1])
  })
 
+ it('returns the the correct active index when a pipette is missing Tip Length Calibrations', () => {
+ when(mockUseAttachedPipettes)
+ .calledWith()
+ .mockReturnValue(mockAttachedPipettesResponse)
+ when(mockUseDeckCalibrationData)
+ .calledWith('otie')
+ .mockReturnValue(mockCompleteDeckCalibration)
+ when(mockUseTipLengthCalibrations)
+ .calledWith('otie')
+ .mockReturnValue(mockIncompleteTipLengthCalibrations)
+ when(mockUsePipetteOffsetCalibrations)
+ .calledWith('otie')
+ .mockReturnValue(mockCompletePipetteOffsetCalibrations) // right mount marked as bad
+ const { result } = renderHook(() => useGenerateTaskList('otie'), {
+ wrapper,
+ })
+
+ expect(result.current.activeIndex).toEqual([1, 0])
+ })
+
  it('returns the earliest encountered task as the active index when multiple tasks require calibrations', () => {
  when(mockUseAttachedPipettes)
  .calledWith()